Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next] tipc: Use is_broadcast_ether_addr() instead of
 memcmp()
To:     Huang Guobin <huangguobin4@huawei.com>, jmaloy@redhat.com,
        davem@davemloft.net, kuba@kernel.org
Cc:     netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <20200803020055.26822-1-huangguobin4@huawei.com>
From:   Ying Xue <ying.xue@windriver.com>
Message-ID: <d8491b36-d81b-c2e8-de04-fd1c4a1254ba@windriver.com>
Date:   Mon, 3 Aug 2020 21:51:45 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20200803020055.26822-1-huangguobin4@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [128.224.155.99] (60.247.85.82) by HK2PR03CA0062.apcprd03.prod.outlook.com (2603:1096:202:17::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.13 via Frontend Transport; Mon, 3 Aug 2020 14:08:16 +0000
X-Originating-IP: [60.247.85.82]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7613e11e-ee84-4c2e-c4f4-08d837b6ac66
X-MS-TrafficTypeDiagnostic: DM5PR11MB1305:
X-Microsoft-Antispam-PRVS: <DM5PR11MB13059D7E7F2CCFE92D88E27F844D0@DM5PR11MB1305.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:534;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: M/bcp17joLOIuDYODlmUkhAXbXPhTXLA0t3JP5lZmaJ8YBkF9hqNRslEYqYcR0pxH+mitrLuwEg4kTx0e4bJI41XkhtuEM5XmkdipU20OdJqeZcBr3c09RZGKXlWzrQVg+B4fyaX6NNJfauDv06PxwFxRuaC2OkyHnnSk77EkDfLaOSJIN/Y7hrtOUS7cXUG6NO+c7D+vD2Cv8TZJc0D1pUm/9ZMVcD7no6DUC3aIK2unY/vf7QPsJfC0dt57jxyLU1ZzZKog4QkYV0FIS2N0BumAwLkzNey9desjoQvuhg4JlQVSHSffPphXEvktpLW66J5vBRCT13Rp56yoVZOJdjVV6U1+yZyUmpyhUM9rgGnIWjB4D70mejkgUpxa9gcimc1pW8q2g/dXeZRhTngFw9lrS9k8HKPpRsal3XIz7Y2LgI/E8mkekrOe94nbatocWAHz3TGmQC4brQPTaRkTNRhOHRDvN+vcjjBE/6WNJU=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2603.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(346002)(396003)(136003)(376002)(39850400004)(956004)(2616005)(66946007)(66476007)(5660300002)(83380400001)(36756003)(66556008)(6486002)(8936002)(16576012)(44832011)(316002)(52116002)(26005)(6706004)(8676002)(478600001)(2906002)(86362001)(31686004)(6666004)(53546011)(186003)(4326008)(16526019)(31696002)(78286006)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: 61x5U3qVlVS0l51hmHhpKtbNPEJJ6aeulq9WBjJO5po48OCspRVR+aNStdnp0yBJdxe7aFIbd9Ze/v2iUuqgn2XCTy+06WVGPS3wTBACMJ6/LVdagQcnOmlVR/ZTIjMt+R0BSkJa2GyhyPSI7lwBUR496/C23KHQzP3PCxoiZORv8HSLimb4D/T7eL06foIc4L5vUTmxBbxpkL/GQikF/jlHYxvWjYrwq1qUsHBHNyWGk+rxAupgLLbZe+4IiRkTO5BETrm3qDcPISgGTy91zuYx04v3KfPSkEndV/eY5v/AoK6wqJGpXNUWT5sJcU3nC3gMXTF8Z61JcGmP17MHUCVU7letdJe3zT41bqWCwDJ7szfpPYBKe70+fDmPo2cLyqL7xXGxtAG43/FJ2xAkz1fE40TLD9PHMqWqaGjIh4E0w4bowgN+BQXahZxcIyW6ovVCLhXsmvKBEs5yT32p7j0THQhuHcmTrkj1SIwoiZPE7A68N6WO5xSNGUrUfNxUPIBtbyPrFiVnPS5Tm/rPhrSvZgXibwoIGmTsZrHA+anltHqnQijXoTPfKlJn2kKnYb5Alhhkm4zd075mlysBQwgUZSsjr8fLILJgT0cZQ14TCSMIC0UNbc+Hk7fAJryUXq7B+Vu1HgU6Lx8+BtPA7A==
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7613e11e-ee84-4c2e-c4f4-08d837b6ac66
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2020 14:08:19.1465
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aMwuPBA5Ay2m6VvPMhi5sqTDdwjTjBBf+XfhjbMosP6p8nXXOhiXTmaUubtSdWz3hZYz2hFE9hmCjOGcng+qSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1305
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/3/20 10:00 AM, Huang Guobin wrote:
> Using is_broadcast_ether_addr() instead of directly use
> memcmp() to determine if the ethernet address is broadcast
> address.
> 
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
> 
> Signed-off-by: Huang Guobin <huangguobin4@huawei.com>

Acked-by: Ying Xue <ying.xue@windriver.com>

> ---
>  net/tipc/eth_media.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/net/tipc/eth_media.c b/net/tipc/eth_media.c
> index 8b0bb600602d..c68019697cfe 100644
> --- a/net/tipc/eth_media.c
> +++ b/net/tipc/eth_media.c
> @@ -62,12 +62,10 @@ static int tipc_eth_raw2addr(struct tipc_bearer *b,
>  			     struct tipc_media_addr *addr,
>  			     char *msg)
>  {
> -	char bcast_mac[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
> -
>  	memset(addr, 0, sizeof(*addr));
>  	ether_addr_copy(addr->value, msg);
>  	addr->media_id = TIPC_MEDIA_TYPE_ETH;
> -	addr->broadcast = !memcmp(addr->value, bcast_mac, ETH_ALEN);
> +	addr->broadcast = is_broadcast_ether_addr(addr->value);
>  	return 0;
>  }
>  
>