Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2103361pxa; Mon, 3 Aug 2020 07:34:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3egSzyWZFxUA+nbwJXGdNAkvGwbKw32En5RCzstpY4ALqHVbv6+XvwZFMF3ey666DM1ht X-Received: by 2002:a17:906:a0c8:: with SMTP id bh8mr17890314ejb.190.1596465270607; Mon, 03 Aug 2020 07:34:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596465270; cv=none; d=google.com; s=arc-20160816; b=KGK9Y7EHWhpUgrd5p3Jr3jLhxN0Uppgr5h6sEFdDjb5JK7N2dDoutBxwomnqZ98qlq RISLObl3Anf7FOc5bzuU1eOThRUX5AyOJmq21rntl9ipsXjhqPDN6NSyPjywtC9yFIQL CaaIch2DVJvrmMonDe1oYRA2noJqpL3aPFhG8hfjk7Q0UKNwo0TOyDCBmboi0pPBYWol bMue6usU6d+Ew51IdgPuQQnLsTkVt3Zh1WXFtlumK6QqKVfhYkXA/ug2vbkLnjYSi2V3 7E9jYaP/lbJB93hRG4kXUB4sdoQr9hUMhXZz2rvWD1IFpzB6OhM8YL7vtBHgTyk3V/WS m8TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=iUV8Rq02NHrLtlZzxCAS8hF7HNXnqGGjn2INw9P8wC0=; b=WggLSimw7BbA9H9mRiFzi90McDidj3MSJQefWoAf4QwVHU4hBSSFsG2R1JPs+yRFir 5NEUXbx/XnaFZzSiGxh1kKyixa0ONl2BKD28myP+4cgeL7QiHC4KLe6sCn4Cf3ENpxNY W4i4cJk3JqlSkHzhO7wDVGp2JgEELdle+gDpq08uN0b5wZpykyfguMglhoYKaoMHOUst vIVaJ7bAma2m9D3PvHTeUFPZLDC/Ne/d0holEftJlKgd6qg41w9evXewDRNjj4dzGuOQ E+gAzGPBIDRLBHShJ8jYsoz0prEza0EfRdy5Z+Mww4J3r3eIu6eNdFviCUlUQlTYTqAQ gVDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu19si561386ejb.305.2020.08.03.07.34.08; Mon, 03 Aug 2020 07:34:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728391AbgHCOdY (ORCPT + 99 others); Mon, 3 Aug 2020 10:33:24 -0400 Received: from www62.your-server.de ([213.133.104.62]:42952 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726358AbgHCOdX (ORCPT ); Mon, 3 Aug 2020 10:33:23 -0400 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1k2bWb-00089n-50; Mon, 03 Aug 2020 16:33:13 +0200 Received: from [178.196.57.75] (helo=pc-9.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2bWa-0008QJ-56; Mon, 03 Aug 2020 16:33:12 +0200 Subject: Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump() To: Tianjia Zhang , ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, andriin@fb.com, john.fastabend@gmail.com, kpsingh@chromium.org, quentin@isovalent.com, kuba@kernel.org, toke@redhat.com, tklauser@distanz.ch, jolsa@kernel.org Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, tianjia.zhang@alibaba.com References: <20200802111540.5384-1-tianjia.zhang@linux.alibaba.com> From: Daniel Borkmann Message-ID: <31eeb5d8-160a-64b8-9a39-a28add59ec74@iogearbox.net> Date: Mon, 3 Aug 2020 16:33:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200802111540.5384-1-tianjia.zhang@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.3/25892/Sun Aug 2 17:01:36 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/2/20 1:15 PM, Tianjia Zhang wrote: > In case of btf_id does not exist, a negative error code -ENOENT > should be returned. > > Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") > Cc: Andrii Nakryiko > Signed-off-by: Tianjia Zhang Applied, thanks!