Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2127749pxa;
        Mon, 3 Aug 2020 08:09:32 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzNTP6I4zxtzdG3R57qXnpMp1HshIbbs3awz8K+v+4bpcX6X/WpN6YD1wgJsuliYwcNMfi2
X-Received: by 2002:a17:906:8389:: with SMTP id p9mr17404299ejx.391.1596467372392;
        Mon, 03 Aug 2020 08:09:32 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1596467372; cv=none;
        d=google.com; s=arc-20160816;
        b=RBSS0L8O3L8mPp7+6ayZ9u/1lBV0Zq33SKGU5e0PAqoQNlvRCPxcwKURLb0Y5ceWi8
         FdAfgo1wy0F0aUTtenGGkC+pzMpGD0L+d7MpKMnypib+tAB/sP1CuFe74sNNUQYo33HY
         SMqYDKTHXNyfcxwXBlA+SuLt+kYOE6XRoayAnVI25hx2DIu9JtkJKupHQScMEd0mPRug
         IY28if5Jcm+ctQKIeUKG6vnzjhfimBJmBUK9WxkSh630Qiier9lZvTuaG8igH8HF4Org
         e4+AuKbBowN7Akp8LrK0bvYzCv6eszawkzKnpAh6uRNoSLImDWGbL35UG7nt0XaHTr36
         ApYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=e6NgvdPuQ2E/5wWMi/jOBQ8ydSKleYNDhnBiIKD57f4=;
        b=CpFxmZLJaH8y1ejLYkOxuM8dXLtA1X5f4lUrcyedSNKRYDDnbGLl4Ty1eYJNWDEKZs
         +66ctVezeYZu+zdCoPPTYn3WmAqefn2BYhNBwoTxypw9bBzEp09SANm2NNSIYXc/9Ovw
         LllLQjviTyotqW+hQIuq6GVXZALaiT+NUYFQfeAXWteK+JaNufEbM3Dh6cvcKL5PItNT
         c9FOem9dKD+cuFvWBcV9LrvD0ideDOz6IbebAVww6WDNEB9uu7iyUWeh6Du5R1C0oBva
         /WtWrToghp2G5fmsa9NuTQbt5vLrfovgkdASvLGE6yClhW9hWTOVIiYwsT65rcQBwd32
         kF6Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=ICoWVarN;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p22si3915913edq.607.2020.08.03.08.09.09;
        Mon, 03 Aug 2020 08:09:32 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=ICoWVarN;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728023AbgHCPIQ (ORCPT <rfc822;sunnyliangjy@gmail.com>
        + 99 others); Mon, 3 Aug 2020 11:08:16 -0400
Received: from mail.kernel.org ([198.145.29.99]:49036 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726276AbgHCPIP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Aug 2020 11:08:15 -0400
Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id C71A12076E;
        Mon,  3 Aug 2020 15:08:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1596467294;
        bh=Lrbi2rsIAExF59EuLBc7ucnI9amz38W6mCJdKugNiSY=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=ICoWVarNkJzobZx++tnhhJngFcae6r4xhlEqj89aatZag49QjN5O7mXay7bxj7NCH
         JQE6yTT6PfFgtOkugp3ORwOlnC4/BgyQYnlSHTNw08W/1cT7W8D1WHH92PsbDVprvw
         hGrE+qO9QSqdzq+k0XSsdZeJMweV3FqiiRp79DUg=
Date:   Mon, 3 Aug 2020 17:07:56 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Dongdong Yang <contribute.kernel@gmail.com>
Cc:     rjw@rjwysocki.net, viresh.kumar@linaro.org, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        devel@driverdev.osuosl.org, gulinghua@xiaomi.com,
        tanggeliang@xiaomi.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, yangdongdong@xiaomi.com,
        duhui@xiaomi.com, zhangguoquan@xiaomi.com, fengwei@xiaomi.com,
        taojun@xiaomi.com, rocking@linux.alibaba.com, huangqiwu@xiaomi.com
Subject: Re: [PATCH v3] sched: Provide USF for the portable equipment.
Message-ID: <20200803150756.GA1098726@kroah.com>
References: <cover.1596464894.git.yangdongdong@xiaomi.com>
 <23719695ee476715ec54d3310c95d535f8e1391a.1596464896.git.yangdongdong@xiaomi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <23719695ee476715ec54d3310c95d535f8e1391a.1596464896.git.yangdongdong@xiaomi.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 03, 2020 at 10:31:15PM +0800, Dongdong Yang wrote:
> +	/*
> +	 * create a sched_usf in cpu_subsys:
> +	 * /sys/devices/system/cpu/sched_usf/...

I thought I asked you not to use a "raw" kobject, you are making this
much harder than it has to be.

Just use a normal struct device.

Also you failed to document your new sysfs files in Documentation/ABI/
like is required :(

Because of both of those things, this isn't ok as-is, sorry.

greg k-h