Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2152470pxa; Mon, 3 Aug 2020 08:44:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoVFw8xGGhHLtxWk7PuZgcHTgh9EFL43D+xEdi9Ft7yJr5swUktjn39Kr0AhCQZfd8YCly X-Received: by 2002:a17:906:3790:: with SMTP id n16mr16823886ejc.256.1596469452909; Mon, 03 Aug 2020 08:44:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596469452; cv=none; d=google.com; s=arc-20160816; b=ngy1dDMVqXquID7mmYRDtl6vowySb1jh7jztcB180DdfNAcLPGGFe13UlV82MPO6vE Bwmx1irM4OqUr0Cl9Uhuy8nzd7nJYrrk5EpvsnCK7Ur+sR+oq6lhdf+X+uEZTwHr+j6p kkS3u9X3guNqzpYlJhEQ6fO+mqoJPe7AV5XOKrNK5Ik8auTQjey90talA9KcEYSyEzOg EhrsSc4hyNrwXjVm6nWMvhr6zRmdtAkUxoYfR/eumYUGsM4Fkt9yW7ZitRadM+Hvvai+ NHjMT3kze0AV/T9ZJjhct9dgoLAWM3IkhmEsO6tUrGTAoeKwtabUhsmG+laBe50PR9w2 /+gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from; bh=uZgxrGDkUOMRSXaG0qPPXkX0uRgXXAAvq4AEaGdQuMg=; b=h+EQ9fgm2X0XWMclLwcpOE/3lzdqgjw97euSiFl3tAizs9LrkhARnyguIp1jAHABDc z4UbKnbMDe6WkKwl3e2DDZLA5BCNpSTDhjAtJs08Qhz5inm/7SjWEp8D+1VI3+lLdGHj w75k75IMn7ZHjfQwugY6ZpdbNF7s4nsBQbs9kfQdFMD9Wc1Hi3XnCu1r3h/TkbgazrdI vUE/F/YkZrrhThQ5xydNniMK6kRV2Yb6EHZHiT5kHm14GXRyaeQbhdXSimpQEKuMZx98 t6/VFL3RVBBmfrmgGkRiNPNRsxwwan98VmQvICveP5McVEm6FNHFNcXt/HT8vVBZxZVh AF4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=B5PQJu+D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j8si10355475eje.539.2020.08.03.08.43.51; Mon, 03 Aug 2020 08:44:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=B5PQJu+D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728038AbgHCPmf (ORCPT + 99 others); Mon, 3 Aug 2020 11:42:35 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:1767 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727982AbgHCPme (ORCPT ); Mon, 3 Aug 2020 11:42:34 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 03 Aug 2020 08:42:20 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 03 Aug 2020 08:42:34 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 03 Aug 2020 08:42:34 -0700 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 3 Aug 2020 15:42:33 +0000 Received: from hqnvemgw03.nvidia.com (10.124.88.68) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 3 Aug 2020 15:42:33 +0000 Received: from skomatineni-linux.nvidia.com (Not Verified[10.2.167.221]) by hqnvemgw03.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Mon, 03 Aug 2020 08:42:33 -0700 From: Sowjanya Komatineni To: , , , , , , , CC: , , , , , Subject: [PATCH v8 05/10] media: tegra-video: Separate CSI stream enable and disable implementations Date: Mon, 3 Aug 2020 08:42:21 -0700 Message-ID: <1596469346-937-6-git-send-email-skomatineni@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1596469346-937-1-git-send-email-skomatineni@nvidia.com> References: <1596469346-937-1-git-send-email-skomatineni@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1596469340; bh=uZgxrGDkUOMRSXaG0qPPXkX0uRgXXAAvq4AEaGdQuMg=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:X-NVConfidentiality:MIME-Version: Content-Type; b=B5PQJu+DTgGLMJ0RGrPt79gOFq0SEWDe+YNVFPe9cJSl0HIgkUTn43R6iG0vAOC+K cfpVxI/VniwJwDTUrmAwczlIn3RvpmrQTjO15VUv9OU8XxdahdQTJE3n4e7F0VtQ4l koV6t5OuVrQK+to0evMYDK06oxudYpPXdmPib26nf7Y6pSD0h0jF95bNr9I31SVWIk wSMA4XYGoLbY68MBOwCTnw0KtwoeO2R5GP88U2UTVDM6x0nzzzHmNduBQnqzru6LhH f4BelJc6M4U4AinEwHR0fwAO9cFz9VIc0oT0ps10C9x/X6vjLEwnBVmT15CtgRE3lg 0pbBuIZFE2mLQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch separates implementation of CSI stream enable and disable into separate functions for readability. Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/csi.c | 51 ++++++++++++++++++++++----------- 1 file changed, 35 insertions(+), 16 deletions(-) diff --git a/drivers/staging/media/tegra-video/csi.c b/drivers/staging/media/tegra-video/csi.c index fb667df..cfe6187 100644 --- a/drivers/staging/media/tegra-video/csi.c +++ b/drivers/staging/media/tegra-video/csi.c @@ -232,34 +232,53 @@ static int tegra_csi_g_frame_interval(struct v4l2_subdev *subdev, return 0; } -static int tegra_csi_s_stream(struct v4l2_subdev *subdev, int enable) +static int tegra_csi_enable_stream(struct v4l2_subdev *subdev) { struct tegra_vi_channel *chan = v4l2_get_subdev_hostdata(subdev); struct tegra_csi_channel *csi_chan = to_csi_chan(subdev); struct tegra_csi *csi = csi_chan->csi; - int ret = 0; + int ret; + + ret = pm_runtime_get_sync(csi->dev); + if (ret < 0) { + dev_err(csi->dev, "failed to get runtime PM: %d\n", ret); + pm_runtime_put_noidle(csi->dev); + return ret; + } csi_chan->pg_mode = chan->pg_mode; - if (enable) { - ret = pm_runtime_get_sync(csi->dev); - if (ret < 0) { - dev_err(csi->dev, - "failed to get runtime PM: %d\n", ret); - pm_runtime_put_noidle(csi->dev); - return ret; - } + ret = csi->ops->csi_start_streaming(csi_chan); + if (ret < 0) + goto rpm_put; - ret = csi->ops->csi_start_streaming(csi_chan); - if (ret < 0) - goto rpm_put; + return 0; - return 0; - } +rpm_put: + pm_runtime_put(csi->dev); + return ret; +} + +static int tegra_csi_disable_stream(struct v4l2_subdev *subdev) +{ + struct tegra_csi_channel *csi_chan = to_csi_chan(subdev); + struct tegra_csi *csi = csi_chan->csi; csi->ops->csi_stop_streaming(csi_chan); -rpm_put: pm_runtime_put(csi->dev); + + return 0; +} + +static int tegra_csi_s_stream(struct v4l2_subdev *subdev, int enable) +{ + int ret; + + if (enable) + ret = tegra_csi_enable_stream(subdev); + else + ret = tegra_csi_disable_stream(subdev); + return ret; } -- 2.7.4