Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200803131948.41736-1-yuehaibing@huawei.com>
In-Reply-To: <20200803131948.41736-1-yuehaibing@huawei.com>
From:   Brian Vazquez <brianvv@google.com>
Date:   Mon, 3 Aug 2020 09:21:45 -0700
Message-ID: <CAMzD94TUnEwAtEHk9+87K964vE8sVxGZUVoZS-LjyZJKS+-O4Q@mail.gmail.com>
Subject: Re: [PATCH net-next] fib: Fix undef compile warning
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     "David S . Miller" <davem@davemloft.net>, kuba@kernel.org,
        Randy Dunlap <rdunlap@infradead.org>,
        Linux NetDev <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Acked-By: Brian Vazquez <brianvv@google.com>

On Mon, Aug 3, 2020 at 6:20 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> net/core/fib_rules.c:26:7: warning: "CONFIG_IP_MULTIPLE_TABLES" is not defined, evaluates to 0 [-Wundef]
>  #elif CONFIG_IP_MULTIPLE_TABLES
>        ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 8b66a6fd34f5 ("fib: fix another fib_rules_ops indirect call wrapper problem")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  net/core/fib_rules.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
> index a7a3f500a857..51678a528f85 100644
> --- a/net/core/fib_rules.c
> +++ b/net/core/fib_rules.c
> @@ -23,7 +23,7 @@
>  #else
>  #define INDIRECT_CALL_MT(f, f2, f1, ...) INDIRECT_CALL_1(f, f2, __VA_ARGS__)
>  #endif
> -#elif CONFIG_IP_MULTIPLE_TABLES
> +#elif defined(CONFIG_IP_MULTIPLE_TABLES)
>  #define INDIRECT_CALL_MT(f, f2, f1, ...) INDIRECT_CALL_1(f, f1, __VA_ARGS__)
>  #else
>  #define INDIRECT_CALL_MT(f, f2, f1, ...) f(__VA_ARGS__)
> --
> 2.17.1
>
>