Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2307873pxa; Mon, 3 Aug 2020 12:45:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxj9KFk/BwSpVOXe/85fJsY3JJK9YZ/ba2vUemuWoPHN9gWR1LGZxEqb781HiVrSuS5SGm X-Received: by 2002:a05:6402:896:: with SMTP id e22mr5366777edy.210.1596483903133; Mon, 03 Aug 2020 12:45:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596483903; cv=none; d=google.com; s=arc-20160816; b=gxGbSHW1uHnNJ5N3wJJ74SBpxESJB8dkWd4pumbOAulAgKsnPAQcmQ+aLZ9PuVKIWt cc2pyZdAjaBkcs0Sp0c4DrNFPu6ExtdpcJJ9xje6hsVu1Dt/Rr4uVohk5y7vaBeIy8yC 6A28QX9gvk86ee2fwR0QL0z5diAyvWL1k0yde5ks9AdGRt9nwCfKbUQjdMZ4ZfMKst2I i7vLmBqdFYoW7k0GU4Ew/IwEdw4IZCGjrLnKigCOt2VeZxRj3flbVOb0OyjXZPsSs54N 9LEJXUbnXIh19WJaNuAcTN46iIHnjrL7Z40Q4ME/n+4up/m9En+19dlwhXd5RNXUMNXb gRIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=SxKVXn46TwSkcYdjEpV4QKWqBuzurVp+Y2dmjVd7CqM=; b=Htq2ohhyj91O20ZmLe1oKMK1FwgWpMeYg78gaN0821NenHvMrd7zeGtP/bw4A3Eqxk PwQ+z5ZMJqu6rvGwc6zg3ug1YzPmmmLj+rz1ZyVgaCjDKtuSuY9EtL2PGxV7zKN0a3hw 21fls6tjNd04+rHGgc3R33rWjfb9CZZ1E1/KTNcySPM0o+WbGgGMZgT8BKycuOmurUc2 cGEttZTxBRpo1p+33KTyHtcwuBQIs1qbptvRAOtDqKgpL2aqXqOWDQVFoYaAqIEDlfDi Va/1XIs1NVYkOhTd9dvFRcA3zt7RXrF6KTUJ6Pq1Sr4rnSTriJeWTZoABfYFU860cmTH KGFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tWs8XaIn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn20si15956097ejc.409.2020.08.03.12.44.40; Mon, 03 Aug 2020 12:45:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tWs8XaIn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728133AbgHCTmb (ORCPT + 99 others); Mon, 3 Aug 2020 15:42:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:56204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726906AbgHCTmb (ORCPT ); Mon, 3 Aug 2020 15:42:31 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D646E22C9F; Mon, 3 Aug 2020 19:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596483750; bh=pg1yMp3Q6hDfDOvtQhZxujnkBMxKrKHKTXX1bU4UQxY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=tWs8XaIn8vAigHR7QF1lMHkQPrbO+/FaTzgbe2uremBsSrlQGNLLcQPmE3I853jNz ZtcIi1hFvzQTLRvU2h9u34eJ/fcrfk5MqNg4rE58AN9GAya57cen3qFmMIDONLeDCS DwGTePIDL7f1t5brhdkxztm8qmlwrRZLttCgrDKE= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1596072174-16358-2-git-send-email-Anson.Huang@nxp.com> References: <1596072174-16358-1-git-send-email-Anson.Huang@nxp.com> <1596072174-16358-2-git-send-email-Anson.Huang@nxp.com> Subject: Re: [PATCH V9 1/6] clk: imx6sl: Use BIT(x) to avoid shifting signed 32-bit value by 31 bits From: Stephen Boyd Cc: Linux-imx@nxp.com To: Anson Huang , abel.vesa@nxp.com, aisheng.dong@nxp.com, arnd@arndb.de, daniel.baluta@nxp.com, festevam@gmail.com, fugang.duan@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, peng.fan@nxp.com, s.hauer@pengutronix.de, shawnguo@kernel.org, yuehaibing@huawei.com Date: Mon, 03 Aug 2020 12:42:29 -0700 Message-ID: <159648374959.1360974.3090613408656313501@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Anson Huang (2020-07-29 18:22:49) > Use readl_relaxed() instead of __raw_readl(), and use BIT(x) > instead of (1 << X) to fix below build warning reported by kernel > test robot: >=20 > drivers/clk/imx/clk-imx6sl.c:149:49: warning: Shifting signed 32-bit > value by 31 bits is undefined behaviour [shiftTooManyBitsSigned] > while (!(__raw_readl(anatop_base + PLL_ARM) & BM_PLL_ARM_LOCK)) >=20 > Signed-off-by: Anson Huang > Reported-by: kernel test robot > --- Reviewed-by: Stephen Boyd