Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200803151134.3740544-1-shorne@gmail.com>
In-Reply-To: <20200803151134.3740544-1-shorne@gmail.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 3 Aug 2020 21:50:59 +0200
Message-ID: <CAK8P3a1m=PPg1sDdRsCz7BOu44-zD87b80SvdZbMuvfLTWsc-A@mail.gmail.com>
Subject: Re: [PATCH] asm-generic/io.h: Fix sparse warnings on big-endian architectures
To:     Stafford Horne <shorne@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        linux-arch <linux-arch@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 3, 2020 at 5:11 PM Stafford Horne <shorne@gmail.com> wrote:
>
> On big-endian architectures like OpenRISC, sparse outputs below warnings on
> asm-generic/io.h.  This is due to io statements like:
>
>   __raw_writel(cpu_to_le32(value), PCI_IOBASE + addr);
>
> The __raw_writel() function expects native endianness, however
> cpu_to_le32() returns __le32.  On little-endian machines these match up
> and there is no issue.  However, on big-endian we get warnings, for IO
> that is defined as little-endian the mismatch is expected.
>
> The fix I propose is to __force to native endian.
>
> Warnings:
>
> ./include/asm-generic/io.h:166:15: warning: cast to restricted __le16
> ./include/asm-generic/io.h:166:15: warning: cast to restricted __le16
> ./include/asm-generic/io.h:166:15: warning: cast to restricted __le16
> ./include/asm-generic/io.h:166:15: warning: cast to restricted __le16
> ./include/asm-generic/io.h:179:15: warning: cast to restricted __le32
> ./include/asm-generic/io.h:179:15: warning: cast to restricted __le32
> ./include/asm-generic/io.h:179:15: warning: cast to restricted __le32
> ./include/asm-generic/io.h:179:15: warning: cast to restricted __le32
> ./include/asm-generic/io.h:179:15: warning: cast to restricted __le32
> ./include/asm-generic/io.h:179:15: warning: cast to restricted __le32
> ./include/asm-generic/io.h:215:22: warning: incorrect type in argument 1 (different base types)
> ./include/asm-generic/io.h:215:22:    expected unsigned short [usertype] value
> ./include/asm-generic/io.h:215:22:    got restricted __le16 [usertype]
> ./include/asm-generic/io.h:225:22: warning: incorrect type in argument 1 (different base types)
> ./include/asm-generic/io.h:225:22:    expected unsigned int [usertype] value
> ./include/asm-generic/io.h:225:22:    got restricted __le32 [usertype]
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>

Looks good to me.

Acked-by: Arnd Bergmann <arnd@arndb.de>

Can you just merge that through your openrisc tree? I don't have
any other asm-generic changes for this merge window.