Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   David Hildenbrand <david@redhat.com>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v2 13/24] virtio_mem: correct tags for config space fields
Date:   Mon, 3 Aug 2020 23:23:55 +0200
Message-Id: <CB3AAE22-6BCA-448E-B499-AA4554755518@redhat.com>
References: <20200803205814.540410-14-mst@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        Jason Wang <jasowang@redhat.com>,
        David Hildenbrand <david@redhat.com>
In-Reply-To: <20200803205814.540410-14-mst@redhat.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Am 03.08.2020 um 22:59 schrieb Michael S. Tsirkin <mst@redhat.com>:
>=20
> =EF=BB=BFSince this is a modern-only device,
> tag config space fields as having little endian-ness.
>=20
> TODO: check other uses of __virtioXX types in this header,
> should probably be __leXX.

Doesn=E2=80=98t matter in practice IIRC, like this change. But we could do i=
t (the spec documents everything as __le) in case it makes things clearer.

Acked-by: David Hildenbrand <david@redhat.com>

>=20
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/uapi/linux/virtio_mem.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>=20
> diff --git a/include/uapi/linux/virtio_mem.h b/include/uapi/linux/virtio_m=
em.h
> index a9ffe041843c..70e01c687d5e 100644
> --- a/include/uapi/linux/virtio_mem.h
> +++ b/include/uapi/linux/virtio_mem.h
> @@ -185,27 +185,27 @@ struct virtio_mem_resp {
>=20
> struct virtio_mem_config {
>    /* Block size and alignment. Cannot change. */
> -    __u64 block_size;
> +    __le64 block_size;
>    /* Valid with VIRTIO_MEM_F_ACPI_PXM. Cannot change. */
> -    __u16 node_id;
> +    __le16 node_id;
>    __u8 padding[6];
>    /* Start address of the memory region. Cannot change. */
> -    __u64 addr;
> +    __le64 addr;
>    /* Region size (maximum). Cannot change. */
> -    __u64 region_size;
> +    __le64 region_size;
>    /*
>     * Currently usable region size. Can grow up to region_size. Can
>     * shrink due to VIRTIO_MEM_REQ_UNPLUG_ALL (in which case no config
>     * update will be sent).
>     */
> -    __u64 usable_region_size;
> +    __le64 usable_region_size;
>    /*
>     * Currently used size. Changes due to plug/unplug requests, but no
>     * config updates will be sent.
>     */
> -    __u64 plugged_size;
> +    __le64 plugged_size;
>    /* Requested size. New plug requests cannot exceed it. Can change. */
> -    __u64 requested_size;
> +    __le64 requested_size;
> };
>=20
> #endif /* _LINUX_VIRTIO_MEM_H */
> --=20
> MST
>=20