Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   David Hildenbrand <david@redhat.com>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v2 01/24] virtio_balloon: fix sparse warning
Date:   Mon, 3 Aug 2020 23:25:44 +0200
Message-Id: <D9D808BB-4A2F-459D-8E2C-CC0C6E0D5C99@redhat.com>
References: <20200803205814.540410-2-mst@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        Jason Wang <jasowang@redhat.com>,
        David Hildenbrand <david@redhat.com>
In-Reply-To: <20200803205814.540410-2-mst@redhat.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Am 03.08.2020 um 22:58 schrieb Michael S. Tsirkin <mst@redhat.com>:
>=20
> =EF=BB=BFballoon uses virtio32_to_cpu instead of cpu_to_virtio32
> to convert a native endian number to virtio.
> No practical difference but makes sparse warn.
> Fix it up.
>=20
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

I think I acked this one already.

Acked-by: David Hildenbrand <david@redhat.com>

> ---
> drivers/virtio/virtio_balloon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_ballo=
on.c
> index 54fd989f9353..8bc1704ffdf3 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -600,7 +600,7 @@ static int send_cmd_id_start(struct virtio_balloon *vb=
)
>    while (virtqueue_get_buf(vq, &unused))
>        ;
>=20
> -    vb->cmd_id_active =3D virtio32_to_cpu(vb->vdev,
> +    vb->cmd_id_active =3D cpu_to_virtio32(vb->vdev,
>                    virtio_balloon_cmd_id_received(vb));
>    sg_init_one(&sg, &vb->cmd_id_active, sizeof(vb->cmd_id_active));
>    err =3D virtqueue_add_outbuf(vq, &sg, 1, &vb->cmd_id_active, GFP_KERNEL=
);
> --=20
> MST
>=20