Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   David Hildenbrand <david@redhat.com>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v2 05/24] virtio_balloon: correct tags for config space fields
Date:   Mon, 3 Aug 2020 23:26:46 +0200
Message-Id: <1E428D95-19D2-40BA-9C46-CA7B0D823A7E@redhat.com>
References: <20200803205814.540410-6-mst@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        Jason Wang <jasowang@redhat.com>,
        David Hildenbrand <david@redhat.com>
In-Reply-To: <20200803205814.540410-6-mst@redhat.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Am 03.08.2020 um 22:59 schrieb Michael S. Tsirkin <mst@redhat.com>:
>=20
> =EF=BB=BFTag config space fields as having little endian-ness.
> Note that balloon is special: LE even when using
> the legacy interface.
>=20
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Acked-by: David Hildenbrand <david@redhat.com>

> ---
> include/uapi/linux/virtio_balloon.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>=20
> diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virt=
io_balloon.h
> index dc3e656470dd..ddaa45e723c4 100644
> --- a/include/uapi/linux/virtio_balloon.h
> +++ b/include/uapi/linux/virtio_balloon.h
> @@ -45,20 +45,20 @@
> #define VIRTIO_BALLOON_CMD_ID_DONE    1
> struct virtio_balloon_config {
>    /* Number of pages host wants Guest to give up. */
> -    __u32 num_pages;
> +    __le32 num_pages;
>    /* Number of pages we've actually got in balloon. */
> -    __u32 actual;
> +    __le32 actual;
>    /*
>     * Free page hint command id, readonly by guest.
>     * Was previously named free_page_report_cmd_id so we
>     * need to carry that name for legacy support.
>     */
>    union {
> -        __u32 free_page_hint_cmd_id;
> -        __u32 free_page_report_cmd_id;    /* deprecated */
> +        __le32 free_page_hint_cmd_id;
> +        __le32 free_page_report_cmd_id;    /* deprecated */
>    };
>    /* Stores PAGE_POISON if page poisoning is in use */
> -    __u32 poison_val;
> +    __le32 poison_val;
> };
>=20
> #define VIRTIO_BALLOON_S_SWAP_IN  0   /* Amount of memory swapped in */
> --=20
> MST
>=20