Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2364454pxa; Mon, 3 Aug 2020 14:29:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjFlt48UsPp6RIDJEY0Fecm7twadLbz474taxEfRFzWv2ZQBfz9wAXdAxFl2KblFZ1mJ1o X-Received: by 2002:a17:906:178b:: with SMTP id t11mr18089271eje.489.1596490199023; Mon, 03 Aug 2020 14:29:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596490199; cv=none; d=google.com; s=arc-20160816; b=dJbSOxyFft9E4x1IwReWH9AAW7PFQkqIQqPY51giEB8yTzHWYgVpyI3olhEk/b/EJi ySt0kz5szfYgu4AgFxwauQdnSBauAVGr9NY4YieV/2c9gQu2x4HXVRz8m6Ao+c1NTHEJ MQIAXjqY2OpBOIf+4jcXx2KG7RdaFfjuKnfv3X8uo4WBdxRTjb1b0ufc/SfyOCBW3Uc7 pqL+t8hIH5Cvh/xs7wGWY4JrsOCe1SaE0vdka/yz7k3oM6c3guyX5xmq0RWnFXUTZAol Q1Rk2u5XWW5ZSpz2FNlcCpc/MQwpcT6Fb6kPoNqgr3ZhNsCEcLA0qXyisJg2xWU1loXE pJXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=SEWW09/i+04+jjvVuA9NB1iGYFQ/+Gb2zPeEc9SAtPI=; b=GM49ZmacNjH6mempMRqezk0G0/CbZMCC88PA9d08dhwuATqcMLOMjsF8And0AyHPOI Mp4l5I7FTcmBo3A/3tBzWRgLk3hjNSc31P61VLRWan7n/c/Ws/jDwFT4PwUspjcLgcoX 4K0Y0G7SM7Da+bQWFQdOecOtqQsIM7bRC3WmliQNjUg/3BrXP39LLnpYO3iRcV8OyBNa gmvoe+pA9RmStBEcudp0QJjA5jgp1rOC9FsBCwnmZAY3iWbvp7tKAi1sIw446JZn6PBZ a+Y1RtPIZLHZl3Kf+4OJtnT3WcypByTq37bLa/F3tCOs3+wTvq0f3DkOHnhQ+NnKnu+Z mo7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fKraf1Dq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ds22si9441089ejc.535.2020.08.03.14.29.35; Mon, 03 Aug 2020 14:29:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fKraf1Dq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729088AbgHCV1Y (ORCPT + 99 others); Mon, 3 Aug 2020 17:27:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:47468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726398AbgHCV1X (ORCPT ); Mon, 3 Aug 2020 17:27:23 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACF2C207DF; Mon, 3 Aug 2020 21:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596490043; bh=SEWW09/i+04+jjvVuA9NB1iGYFQ/+Gb2zPeEc9SAtPI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=fKraf1DqTK0sVAU2Wtz2SmkZ8NLOotp3LiIuxM3o3RlO6RPHjb25lL4EmJ4Klx/rT TNxFCNmgzFyC7a6fKwBaVGUPHU4sHqw3J9DCkXSMrNi2k4fiO8OJcLyoLrp26e/+0L i2jpkTYD8p0EVnDCgqcjs8Dt6NYUqq2NR9tOs+9o= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200730182619.23246-1-nsaenzjulienne@suse.de> References: <20200730182619.23246-1-nsaenzjulienne@suse.de> Subject: Re: [PATCH v2] clk: bcm2835: Do not use prediv with bcm2711's PLLs From: Stephen Boyd Cc: pbrobinson@gmail.com, kernel-list@raspberrypi.com, Nathan Chancellor , Michael Turquette , linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Eric Anholt , Florian Fainelli , Matthias Brugger , Nicolas Saenz Julienne , Ray Jui , Scott Branden , Stefan Wahren , bcm-kernel-feedback-list@broadcom.com Date: Mon, 03 Aug 2020 14:27:22 -0700 Message-ID: <159649004236.1360974.8603728575729464532@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Nicolas Saenz Julienne (2020-07-30 11:26:19) > Contrary to previous SoCs, bcm2711 doesn't have a prescaler in the PLL > feedback loop. Bypass it by zeroing fb_prediv_mask when running on > bcm2711. >=20 > Note that, since the prediv configuration bits were re-purposed, this > was triggering miscalculations on all clocks hanging from the VPU clock, > notably the aux UART, making its output unintelligible. >=20 > Fixes: 42de9ad400af ("clk: bcm2835: Add BCM2711_CLOCK_EMMC2 support") > Reported-by: Nathan Chancellor > Signed-off-by: Nicolas Saenz Julienne > --- Applied to clk-next