Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2393159pxa; Mon, 3 Aug 2020 15:14:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxETMXlGrqfbXCSuzUG0uZvDES6Umn5i1/jtca1br4V5+G2H+5GqXAPaYv+Yr4axo3tPx9+ X-Received: by 2002:a17:906:30d9:: with SMTP id b25mr18358632ejb.524.1596492874735; Mon, 03 Aug 2020 15:14:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596492874; cv=none; d=google.com; s=arc-20160816; b=okYtWUfwxsexSVWfVUeDPf9qorcZw2uczBcfaM0SehwfJ82FDKOXnf1LuPKZRgdmAJ Yo0MTuT+1iAEIqaaOUsubw5d2AL6ntdRE2MHTImRfdGWAyhFUw29HfY1uhQa3K/1o0KA 2Hw3xdbmUijEXbNkRoD3W8heul1iiMIE54Ioa/yTLoZ/rPAT3JnKYdQpem9QHqAreF77 OpXOKwaMYpjW1aNCtwjDOFd1C7txFHou7xhVFDKITO9wTvbwi+bvadKaZeK10VZmu5hE +rTwYv99Td2D86AZo154WLxxutZAdujpP/s8nJeWh1tOXvD6Tdem0VhTgdcz6PnvY2hG ErkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=cWIQaLEbf1uPZOrTSJZuobXY9JyM8O0le4VdVjgJm28=; b=d2Lo12g3Q7uE6q3NTjrjYN4IpCkA0T5oVXJhQbCZDS9sQWnclnh1+Q5AklAQXRBRmq 4Vjq4vLr6o93jlawHgYL0t8vGHMEdd142o1tulnVVdwaL4UmPC4kNayca+t04pRuK9LP Zhk35hT0QJwKqK+AaJiZzuc2D5IyyoD1NDRgMN9cjHqKL0XhBx6557BK/6Boq1M4IyQv F6FtYsWjkM5VfdqqlIUbk0YT1a/Qh6ZiRuNKpZI0ZHkfIn1Vn0sHHksmQq9mMg96nrQ8 pvRgruEs+8/NVbuVt0/SoqOEXOTku1gXt0Gm87FCMdDh5lxtCnNmdC5195ITdpFr+z9C PupA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m9si10696889ejq.390.2020.08.03.15.14.11; Mon, 03 Aug 2020 15:14:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728308AbgHCWKk (ORCPT + 99 others); Mon, 3 Aug 2020 18:10:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgHCWKk (ORCPT ); Mon, 3 Aug 2020 18:10:40 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BA6EC06174A; Mon, 3 Aug 2020 15:10:40 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 95F0712771D66; Mon, 3 Aug 2020 14:53:53 -0700 (PDT) Date: Mon, 03 Aug 2020 15:10:38 -0700 (PDT) Message-Id: <20200803.151038.440269686968773655.davem@davemloft.net> To: yepeilin.cs@gmail.com Cc: pshelar@ovn.org, kuba@kernel.org, dan.carpenter@oracle.com, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH net] openvswitch: Prevent kernel-infoleak in ovs_ct_put_key() From: David Miller In-Reply-To: <20200731044838.213975-1-yepeilin.cs@gmail.com> References: <20200731044838.213975-1-yepeilin.cs@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Aug 2020 14:53:54 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peilin Ye Date: Fri, 31 Jul 2020 00:48:38 -0400 > ovs_ct_put_key() is potentially copying uninitialized kernel stack memory > into socket buffers, since the compiler may leave a 3-byte hole at the end > of `struct ovs_key_ct_tuple_ipv4` and `struct ovs_key_ct_tuple_ipv6`. Fix > it by initializing `orig` with memset(). > > Cc: stable@vger.kernel.org Please don't CC: stable for networking fixes. > Fixes: 9dd7f8907c37 ("openvswitch: Add original direction conntrack tuple to sw_flow_key.") > Suggested-by: Dan Carpenter > Signed-off-by: Peilin Ye Applied and queued up for -stable, thank you.