Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2393420pxa; Mon, 3 Aug 2020 15:14:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuyweSaAmOo3wleeFwiH3P2/zxpdOyO030YDHslIAzjWwQ9KPeac0RhTTH2NBGLAV7G5w8 X-Received: by 2002:aa7:c983:: with SMTP id c3mr17618938edt.383.1596492898816; Mon, 03 Aug 2020 15:14:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596492898; cv=none; d=google.com; s=arc-20160816; b=BmgLD9a9pT2g+i7hRrTHd8DNg2v5u+a1vWO1/Fe+GoeEzGyK5pfColRw1qE4ZCz76C SwL63P/M18Wo3Dl+8svwycHdkT2cy8wj6R1nIznOlAuIV2aO9AElSeVBRNlk+iyeaNa4 S9nArmJtXJwsLRqEbrVfksvf4uJCx9cRYhxKu15yaegZvetaEpxECMg/nMobeggVzcrH iXvFpKI5eEwY6nEgERxcvDfzA6wRSqhRU18edmic+hzLSZhWbkmrJaJmJlnmIaG1Fjmn yHCiqRiLHsRFcqU9CdlCIjw1NkwBjK0J0EjJUyRzkdE0KyqZpbcjJwcoYkhiQ2DfzH1z LAKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Dv+o4sJ7FMgJnhB/TwFNeWtUeN/vBpYAhImSnQKFfok=; b=SDfPIRFKHS0MtVyU3lomsWPhdMSNGNZ/DJwVpdND1VILJpUT8J38DJFLS/IOd5l+M3 M+jPyVgs/o6og547fdm43aJF9o97j7xvIxjmPOdz0I6SG6OEAvCPpo8L3mmGTX+cOAEx bqtZsxJ5T0uBqpq78Y35DtjXWvASLuNGeOBLYPRtLZaD9fgApXUD2munbiCKVm9LOMB0 d19xwwvr7Q8s7uWXKx6lY+cZKA1sX6rNVFS9HNVfQgUCMKMbcqIyWFTeMefFm32igfX/ vBdK3OgpBEbE9e6YHvlBwYM4v680gtV75ttE7bDI8rnQMMQFyh1mPqWEp2KQrwK8W7ec xGwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r1si278512ejp.282.2020.08.03.15.14.37; Mon, 03 Aug 2020 15:14:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728613AbgHCWMY (ORCPT + 99 others); Mon, 3 Aug 2020 18:12:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727959AbgHCWMY (ORCPT ); Mon, 3 Aug 2020 18:12:24 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F253C06174A; Mon, 3 Aug 2020 15:12:24 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 10EC512771D6C; Mon, 3 Aug 2020 14:55:38 -0700 (PDT) Date: Mon, 03 Aug 2020 15:12:22 -0700 (PDT) Message-Id: <20200803.151222.446729320721620447.davem@davemloft.net> To: gaurav1086@gmail.com Cc: kuba@kernel.org, mkubecek@suse.cz, f.fainelli@gmail.com, andrew@lunn.ch, linux@rempel-privat.de, yuehaibing@huawei.com, ayal@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net/ethtool] ethnl_set_linkmodes: remove redundant null check From: David Miller In-Reply-To: <20200731045908.32466-1-gaurav1086@gmail.com> References: <20200731045908.32466-1-gaurav1086@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Aug 2020 14:55:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gaurav Singh Date: Fri, 31 Jul 2020 00:58:44 -0400 > info cannot be NULL here since its being accessed earlier > in the function: nlmsg_parse(info->nlhdr...). Remove this > redundant NULL check. > > Signed-off-by: Gaurav Singh Applied, thank you.