Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200731100248.26982-1-nsaenzjulienne@suse.de>
 <CAL_JsqKu4CB7-b_hRvu63c9jQ_S91epWMr=P__9Fu-h_WFR-_Q@mail.gmail.com> <9200970a917a9cabdc5b17483b5a8725111eb9d0.camel@suse.de>
In-Reply-To: <9200970a917a9cabdc5b17483b5a8725111eb9d0.camel@suse.de>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Mon, 3 Aug 2020 16:27:39 -0600
Message-ID: <CAL_Jsq+oQyQhAaB-jP8MxKp9jTEbr4c0oxPY5FiwmQRcnqJOdg@mail.gmail.com>
Subject: Re: [PATCH] of: unittest: Use bigger address cells to catch parser regressions
To:     Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc:     Frank Rowand <frowand.list@gmail.com>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@lists.infradead.org>,
        Nathan Chancellor <natechancellor@gmail.com>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 3, 2020 at 8:25 AM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> Getting address and size cells for dma-ranges/ranges parsing is tricky
> and shouldn't rely on the node's count_cells() method. The function
> starts looking for cells on the parent node, as its supposed to work
> with device nodes, which doesn't work when input with bus nodes, as
> generally done when parsing ranges.
>
> Add test to catch regressions on that specific quirk as developers will
> be tempted to edit it out in favor of the default method.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
>  drivers/of/unittest-data/tests-address.dtsi | 10 +++++-----
>  drivers/of/unittest.c                       |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)

Applied, thanks.

Rob