Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2409248pxa; Mon, 3 Aug 2020 15:44:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMr78tmW2toiP9ifS/xBCRCZpTTUrG3nZStAdGFqLc9YX1VRHU6i7W9aksfo/uSPtLPOde X-Received: by 2002:a17:906:2b57:: with SMTP id b23mr7621274ejg.26.1596494680720; Mon, 03 Aug 2020 15:44:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596494680; cv=none; d=google.com; s=arc-20160816; b=HSrKVWDQpRiT5me3jGFzMIYE5+GVSXV5i3CgBEsdqbB5pE4ejKb84xmfhHEbuLLzLr lC4atatFZ1dp72JfHxoWr2mHSNgDZqG7zR+JOt00DRqalWuBwf0rL90oEAZ+TdsV7BJA TT81s3a9NQ4C4vieliZA+z+KozZa3DEvYeO/drgQMj6Vx1+LnZnMKTU66lGWfMJ1T3SR PLfhKCasG1TqR9UOWAcSGoKwbPaMYkvHSfW6a1JqBHVG5B7yL1kpOydytDx2rUKiY+Hk hdchQ3xMOc4SnL4kgl6LwS6LqDojyI2fErfHFkZdCynK8U/vjAn4XOirGsc5BHe9qGK8 y5Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=lFsx27GcMAb6M+HPbhV7YgCeHD9h46fDEAYwzzxawRY=; b=YOwIAM+iojzg5jusqvhg82W53ilgl3qlW7NjVGPev7sbsrYmPbdQGGNCLre4A3GK7R epRCA7joWx7HD3gPnFsvByoAZW6/gxB14e5pdj+aRJBA6aFkkhHnGThoT8XQbzNg4hbA erZE8PrhULbt+mJQkWa9WRTBN7k7pa7GNrf1D2Jp/4IawNf5geI6YZPkNYdgG/QySOzf ZzDabrdt2FultcfObEJ5nd61r8ayLXaIiMJOP+WxM6LK83Fj1PcDGL1jAzOcrvh3GLqH ir6O6yUciWtz/hep0gNLj/QtYocEZ7iEeOIhc/xSiYSNfFYZxON6tNrm2K84BoiHnq/3 +dAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=KL8cTaCZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zg2si364511ejb.183.2020.08.03.15.44.18; Mon, 03 Aug 2020 15:44:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=KL8cTaCZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727899AbgHCWl5 (ORCPT + 99 others); Mon, 3 Aug 2020 18:41:57 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:53868 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbgHCWl5 (ORCPT ); Mon, 3 Aug 2020 18:41:57 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 073MbQVp072566; Mon, 3 Aug 2020 22:41:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2020-01-29; bh=lFsx27GcMAb6M+HPbhV7YgCeHD9h46fDEAYwzzxawRY=; b=KL8cTaCZbKMpTXoTjUQ0Dn9Dt/bgySKmrn7zt6fTe1R7oIF4vC+O/HK7gjt8oFMfiivT lKG27MtYue9kOE/AoqP6nJfAv4k2pqDzRGqtPk16Z+x5NHZAcXw7N+FS8O1WZphMc3gq 6Xa4CUqMFhrN0YLnZj0CssaOvyZ9/YJQUv2oRqrqn2QOWNjDEmkN1uv/e3mgxfoffrNW wODbIjyiKVyDYGb+fe8s881po36GasIn6Pdy15Pu14nLwWlej5d+/pkZhC73z7cbTkMK PKgJrreYLFTxMl1nhonQ4f35q0zzzqqBznWhpTXfe3eZJxu9WLGHP/cVyZh0TNuUJUiu Sg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 32pdnq4dts-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 03 Aug 2020 22:41:52 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 073McntC063213; Mon, 3 Aug 2020 22:41:51 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 32pdnp07d9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 03 Aug 2020 22:41:51 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 073Mfo26026448; Mon, 3 Aug 2020 22:41:50 GMT Received: from brm-x32-03.us.oracle.com (/10.80.150.35) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 03 Aug 2020 15:41:50 -0700 From: Jane Chu To: dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, ira.weiny@intel.com, jmoyer@redhat.com, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Cc: jane.chu@oracle.com Subject: [PATCH v2 1/3] libnvdimm/security: fix a typo Date: Mon, 3 Aug 2020 16:41:37 -0600 Message-Id: <1596494499-9852-1-git-send-email-jane.chu@oracle.com> X-Mailer: git-send-email 1.8.3.1 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9702 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008030155 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9702 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 mlxscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008030155 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit d78c620a2e82 ("libnvdimm/security: Introduce a 'frozen' attribute") introduced a typo, causing a 'nvdimm->sec.flags' update being overwritten by the subsequent update meant for 'nvdimm->sec.ext_flags'. Cc: Dan Williams Fixes: d78c620a2e82 ("libnvdimm/security: Introduce a 'frozen' attribute") Signed-off-by: Jane Chu Reviewed-by: Dave Jiang --- drivers/nvdimm/security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvdimm/security.c b/drivers/nvdimm/security.c index 4cef69b..8f3971c 100644 --- a/drivers/nvdimm/security.c +++ b/drivers/nvdimm/security.c @@ -457,7 +457,7 @@ void __nvdimm_security_overwrite_query(struct nvdimm *nvdimm) clear_bit(NDD_WORK_PENDING, &nvdimm->flags); put_device(&nvdimm->dev); nvdimm->sec.flags = nvdimm_security_flags(nvdimm, NVDIMM_USER); - nvdimm->sec.flags = nvdimm_security_flags(nvdimm, NVDIMM_MASTER); + nvdimm->sec.ext_flags = nvdimm_security_flags(nvdimm, NVDIMM_MASTER); } void nvdimm_security_overwrite_query(struct work_struct *work) -- 1.8.3.1