Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 03 Aug 2020 15:51:38 -0700 (PDT)
Message-Id: <20200803.155138.467790375085778952.davem@davemloft.net>
To:     baijiaju@tsinghua.edu.cn
Cc:     3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: eni: avoid accessing the data mapped to streaming
 DMA
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200802091611.24331-1-baijiaju@tsinghua.edu.cn>
References: <20200802091611.24331-1-baijiaju@tsinghua.edu.cn>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Jia-Ju Bai <baijiaju@tsinghua.edu.cn>
Date: Sun,  2 Aug 2020 17:16:11 +0800

> In do_tx(), skb->data is mapped to streaming DMA on line 1111:
>   paddr = dma_map_single(...,skb->data,DMA_TO_DEVICE);
> 
> Then skb->data is accessed on line 1153:
>   (skb->data[3] & 0xf)
> 
> This access may cause data inconsistency between CPU cache and hardware.
> 
> To fix this problem, skb->data[3] is assigned to a local variable before
> DMA mapping, and then the driver accesses this local variable instead of
> skb->data[3].
> 
> Signed-off-by: Jia-Ju Bai <baijiaju@tsinghua.edu.cn>

Applied.