Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2417085pxa; Mon, 3 Aug 2020 15:58:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwo56dlbvrMggJ6fYxw9NGocw+cZEF0G/8ylrCE9wklVlsI904Z9myEZ0swIBf56tjpXO0i X-Received: by 2002:a50:d485:: with SMTP id s5mr18323905edi.285.1596495517564; Mon, 03 Aug 2020 15:58:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596495517; cv=none; d=google.com; s=arc-20160816; b=FOrEZMk75EEtQmrbCVX6ohVNQhx6ZmhACXfWikBgXMYpSyCN0D9c9pSSrGkin/wGP7 xz3m5nLjKH5vq4o209RapF1BdUY/r5skc6DWruDq455wsdUR1wdmWAKmntXAiqkqerDi QNbcPjki78/BIHDk/xpB9jGvUNcN13tHR80jrzP5L9CfbzgzuKf6xYVk4+4msW/FkWor tbkSQD2iJZlaqQ5qGeHyr9YHhvgyMGPR7xwnSaJr0ReEE0xE5QBA3d+Twkl9cdcPNVYK tYOG5xrIfkzUTv0Utw1iqe6/8im4WoHIEB0logLgkhlxiWHhqFrpF5DCo6hXb41L9JtB RgcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=XDxBK364STRK4mUGRBwaLBJTImNDNuklvVvvJpzFoU8=; b=Mj9NxnUvd3e4UbyQExNzSvfz0jH7dhEaXaNdFH3TS1oxmu7+mC2uQjG/G75E4CbvaK VRwMVKZlYXxq7rUmx57y6+6b/qy9aYsGoyVrqK0Q726LFFu4eAtu3sabZxD7v4dVUCRi wrkR0oUpF5+iTCmlFYDCVfqcYfW7MoUtBBC4gY+v2lSlmJQWJ/OliZfwSny7uuVdiBBO pSS7SNjMTkjfiQQ2dseqKGAqJeLRP1O/IuH2kh7kd9WGijdCLZEkDJgceL+X9QjqlY1y Z9fPPa6qarJ4igMjb1nEZrcuycp0QbZKb87RB6m9Nrhhg57xNAtGfYJs7bJ4aDkBcmQH KYaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d18si11366923ejm.684.2020.08.03.15.58.14; Mon, 03 Aug 2020 15:58:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728920AbgHCW6E (ORCPT + 99 others); Mon, 3 Aug 2020 18:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726770AbgHCW6E (ORCPT ); Mon, 3 Aug 2020 18:58:04 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3D10C06174A; Mon, 3 Aug 2020 15:58:03 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E5B2812779164; Mon, 3 Aug 2020 15:41:17 -0700 (PDT) Date: Mon, 03 Aug 2020 15:58:02 -0700 (PDT) Message-Id: <20200803.155802.2215012000142493904.davem@davemloft.net> To: tianjia.zhang@linux.alibaba.com Cc: claudiu.manoil@nxp.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, tianjia.zhang@alibaba.com Subject: Re: [PATCH] net/enetc: Fix wrong return value in enetc_psfp_parse_clsflower() From: David Miller In-Reply-To: <20200802111538.5338-1-tianjia.zhang@linux.alibaba.com> References: <20200802111538.5338-1-tianjia.zhang@linux.alibaba.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Aug 2020 15:41:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tianjia Zhang Date: Sun, 2 Aug 2020 19:15:38 +0800 > In the case of invalid rule, a positive value EINVAL is returned here. > I think this is a typo error. It is necessary to return an error value. > > Cc: Po Liu > Signed-off-by: Tianjia Zhang Applied.