Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2417342pxa;
        Mon, 3 Aug 2020 15:59:03 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzn4B3+Pxa2E3oJz+9vnmqc9q9m9SjChh8w1qui1RFDWhN/7HmdiupwWc0ih8ExaQC3a9U/
X-Received: by 2002:a50:9e4c:: with SMTP id z70mr17537822ede.384.1596495542993;
        Mon, 03 Aug 2020 15:59:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1596495542; cv=none;
        d=google.com; s=arc-20160816;
        b=0ubx9m4WugpwPRzigzNznTR3x0NcD9W6/0oWIFb4d0YH0qLhxENg8Xne9rcLI8jIvd
         0QQ+mIC1GvpGDp0YpsvL1AHFFqRUrKDNNdoj7Kon0n0KznZjXF8i/wGQIfdsnjze6H1T
         QfAtxXRH0ABsfnsuDXQivILCip3rpJaYuyY+67E+gsSVnRyWkCExOY0WTis54eU6fKq6
         CudRVDbsvK2+a9f2g+AWIeOiRfWZm8mOYqrBoedOBKrMqHUvjgKswl6ScYtNUnXgPLJw
         EFUP6oaXZ7M/GZ8EeAoINM76ShCupCbr3236U/T9gmrj1yJ2ys8IC7ja+9UZ3Yuq1g28
         6Ovg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=W72ScwVKXcpZlLCQVzAHd1yUJ0Z/GID7Bk/QHU7+pyU=;
        b=dSYOynzkRz2PnCCj1jxhjQi/MrfqmV5W09EDKZ60XJ4TjEO/sp9onDXkELf9r0aL2H
         AZoqTZJPBxYvODkHLsrfz4aijqvEYU03UVWskZDVNDLQwGiBNHtM/SOJnkbn40VWZSOz
         HahlGjw6c51c7vCheaZzWhtq7aDfNs61toXqQMqBq0X4qjdFoSWADQHmom4pT9MmOxJK
         Ddp8UBqR7bnptjoZQ07LqM1x23w9h5WUzWFbaVijRyqRaYkdi16w1oLiyHEAPPkZNOBE
         xFutMWI8d+nUaXV3yEwPNXXB41CJyOfYuJ08kSSho2xN26HqYDKCPQuDi/cne01NpJBG
         Jwcg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id i18si7238944ejy.434.2020.08.03.15.58.40;
        Mon, 03 Aug 2020 15:59:02 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728970AbgHCW6K (ORCPT <rfc822;ostrlinux@gmail.com> + 99 others);
        Mon, 3 Aug 2020 18:58:10 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55126 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726770AbgHCW6J (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Aug 2020 18:58:09 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DF49C06174A;
        Mon,  3 Aug 2020 15:58:09 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 68BD512779166;
        Mon,  3 Aug 2020 15:41:23 -0700 (PDT)
Date:   Mon, 03 Aug 2020 15:58:08 -0700 (PDT)
Message-Id: <20200803.155808.537689960383956807.davem@davemloft.net>
To:     tianjia.zhang@linux.alibaba.com
Cc:     dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com,
        kuba@kernel.org, ricardo.farrington@cavium.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        tianjia.zhang@alibaba.com
Subject: Re: [PATCH] liquidio: Fix wrong return value in cn23xx_get_pf_num()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200802111544.5520-1-tianjia.zhang@linux.alibaba.com>
References: <20200802111544.5520-1-tianjia.zhang@linux.alibaba.com>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Aug 2020 15:41:23 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Date: Sun,  2 Aug 2020 19:15:44 +0800

> On an error exit path, a negative error code should be returned
> instead of a positive return value.
> 
> Fixes: 0c45d7fe12c7e ("liquidio: fix use of pf in pass-through mode in a virtual machine")
> Cc: Rick Farrington <ricardo.farrington@cavium.com>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

Applied.