Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2434211pxa; Mon, 3 Aug 2020 16:24:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAx9f0CNu2wFFgwnrDtp3t46moLhQ8fbzN38utD2+Zf5qKbHGD7hxbQX6Bxm2E4MyJ3sGa X-Received: by 2002:a17:906:71d3:: with SMTP id i19mr18487363ejk.459.1596497081229; Mon, 03 Aug 2020 16:24:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596497081; cv=none; d=google.com; s=arc-20160816; b=oNmGdAiT5mATFsxxRPi6ENvUNgi/+/5e4abA6vvTLSuwOLBJmlXv7Ufaa68ApS1UjZ r+MkNNmTiI7QMSc0B1DrkH9/yZ7dNVEm4fSJw9oAiDuWFgf++DuynRiPJNDMyLn+Et18 M6JRfojXQHJEJXeeKSm6CIdbGo/DmHruSV2rX0UZQeUZqL3q84gVI8Swhw+j0y0P4LqD lgS/ereavdU4FYASZOitVAFzxlDe0BXPmZl9YoU6DrGJSkmNSvlLyjbQkpAvpsgNCfkH Gj8ig/D13R0MZp0IQ5he4NBO/hPxlzvgpzzXTrqLHh8QRNLyVxJJDXav20EiHBtCeBd4 eEWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=WPyRHPy5zkr15ctnRk4MTKhrldmzjJelPkyLBs/FRYE=; b=zg9151tnaz0hTByFBr5BEp4NiXRqbfRd3Q5BYBA7PmEkLXUIb1BNHO68b0bj3YoVuk /6x6wNoku3k6jBsYKyUrcWNNCjxIC42BgdpuhgtH7ZIKCZasd6Nvw30CYC0FVzbNhcnQ XizzHw7i26wYVMFCAhu6sjm7a0JPUzOGk8XQUe/mZyeijODwVdTj2c8JqZdbbW31hnzc 1TL4fzjEr2Q2RtK8SUkyeTipSZ6y33TfbctrfCRrKvsTGWUERpPdFyPqZ1iLp1SU5LzJ 3hgRUOunoZ0RV9ho/ZME9uoy86ewcao4SxzTbdr/a1QOm4omqoZBfokPp35XfbJu2aGR 70Sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si11406437edy.106.2020.08.03.16.24.19; Mon, 03 Aug 2020 16:24:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729240AbgHCXWE (ORCPT + 99 others); Mon, 3 Aug 2020 19:22:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728891AbgHCXWE (ORCPT ); Mon, 3 Aug 2020 19:22:04 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57BD0C06174A; Mon, 3 Aug 2020 16:22:04 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5E2591277CEBD; Mon, 3 Aug 2020 16:05:18 -0700 (PDT) Date: Mon, 03 Aug 2020 16:22:03 -0700 (PDT) Message-Id: <20200803.162203.547758721051828253.davem@davemloft.net> To: huangguobin4@huawei.com Cc: jmaloy@redhat.com, ying.xue@windriver.com, kuba@kernel.org, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] tipc: Use is_broadcast_ether_addr() instead of memcmp() From: David Miller In-Reply-To: <20200803020055.26822-1-huangguobin4@huawei.com> References: <20200803020055.26822-1-huangguobin4@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Aug 2020 16:05:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huang Guobin Date: Sun, 2 Aug 2020 22:00:55 -0400 > Using is_broadcast_ether_addr() instead of directly use > memcmp() to determine if the ethernet address is broadcast > address. > > spatch with a semantic match is used to found this problem. > (http://coccinelle.lip6.fr/) > > Signed-off-by: Huang Guobin Applied, thank you.