Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2480922pxa; Mon, 3 Aug 2020 17:51:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/CPhZP+7IOvIoXKewuoXKDwgMIWArjTFs+n0ELMAwPgR+AQFgE4WBZyw1S0dlpWUEEOOx X-Received: by 2002:a17:906:8050:: with SMTP id x16mr8364759ejw.441.1596502267656; Mon, 03 Aug 2020 17:51:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596502267; cv=none; d=google.com; s=arc-20160816; b=ShcrTl3uS05EJHnZYpUI+kPZA5JufR3Ei0usYJ98hJJGXNcsoPg5cwj73S8D926O5l ChGb2Edb2VafceERxg9YWSc0dwNdIL10iCdDOsEcBbZGigwkbKP7uXU2wwiR4mJXYnm5 9UWDi7RvKHgXy08Y7WEnHPfXqvGKkUaws3lpJuFGcCdrU0YL3oqpAFCsNIOLSPLBdYje cbq0ABWROXpC37qBoOIyAq19ATMhAH/cmZY7hTW+7HvMhK91JKf7lLzBNCgRD13ht/pc hJwyfm4DZA0mcEJnrqx/6bjbioIWbcH21ahEKnCKBeMSecFknqWsyWTD9QQTp8EmBm7G D7Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pni1o6aoiUKtw/3OfYS97iO3vEt5WV4q/1D+eS1+IJs=; b=l+FM7Yrghs98bUE5A8F8+1w3C5JDpdFN9NxUkNTpgr1btyJX5V6eVZuYoUPMm43IYF LqFTjNmhkqNFOtWtgs8xDwNf+IrLQNJFHCjlBukg3juI6KST2Gj2+aou5GqV2olcIB2W VmkgsO6TkOKe0XmptikkjBzgTDAkaFpYwBpVzIXvllbwjjHCPy0lA7e9MgFYSWF1hCeS KJ00Sxu8mgC0EQWQdFMNgXA8JfkjD0FGg2KMeNR3hwnvK2g8Pfb0tImpvZkKGzEgH0Z2 EMkyJJDp1q1gWEL8Ydw176WuNynTNBi/F9obj1zbQs8RNh7+52s5lsigfqzpEzb/fbTU dm0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZmlhDmNu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay22si12158037edb.569.2020.08.03.17.50.45; Mon, 03 Aug 2020 17:51:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZmlhDmNu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726948AbgHDAsa (ORCPT + 99 others); Mon, 3 Aug 2020 20:48:30 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:44470 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726398AbgHDAsa (ORCPT ); Mon, 3 Aug 2020 20:48:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596502109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pni1o6aoiUKtw/3OfYS97iO3vEt5WV4q/1D+eS1+IJs=; b=ZmlhDmNuaJUuiZ8L/QL3k+b8YCtvUSzkwzN4JFnDg7C+zHykVDe3i7gyoiOSbjE0XZyLrg ZoR/X9yg+vG6WDE+I4iepy7sBLHiJi5odz8TynWlCR2dSbcOy3uww6VbSiFVUXVhcCyfrL CdIrLMr8ySyPeaiqSqWWJM8l8ekRTjw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-228-Q5lytYKUP--GAurLnuzXlQ-1; Mon, 03 Aug 2020 20:48:27 -0400 X-MC-Unique: Q5lytYKUP--GAurLnuzXlQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C60F5100AA23; Tue, 4 Aug 2020 00:48:24 +0000 (UTC) Received: from redhat.com (ovpn-112-64.phx2.redhat.com [10.3.112.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 32DEF5D9F7; Tue, 4 Aug 2020 00:48:21 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.94) (envelope-from ) id 1k2l7p-0008W3-HU; Mon, 03 Aug 2020 20:48:17 -0400 Date: Mon, 3 Aug 2020 20:48:17 -0400 From: "Frank Ch. Eigler" To: Kees Cook Cc: Joe Lawrence , Evgenii Shatokhin , Kristen Carlson Accardi , Miroslav Benes , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, arjan@linux.intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, rick.p.edgecombe@intel.com, live-patching@vger.kernel.org, Josh Poimboeuf , Jessica Yu Subject: Re: [PATCH v4 00/10] Function Granular KASLR Message-ID: <20200804004817.GD30810@redhat.com> References: <20200717170008.5949-1-kristen@linux.intel.com> <202008031043.FE182E9@keescook> <20200803193837.GB30810@redhat.com> <202008031310.4F8DAA20@keescook> <20200803211228.GC30810@redhat.com> <202008031439.F1399A588@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202008031439.F1399A588@keescook> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi - > > We have relocated based on sections, not some subset of function > > symbols accessible that way, partly because DWARF line- and DIE- based > > probes can map to addresses some way away from function symbols, into > > function interiors, or cloned/moved bits of optimized code. It would > > take some work to prove that function-symbol based heuristic > > arithmetic would have just as much reach. > > Interesting. Do you have an example handy? No, I'm afraid I don't have one that I know cannot possibly be expressed by reference to a function symbol only. I'd look at systemtap (4.3) probe point lists like: % stap -vL 'kernel.statement("*@kernel/*verif*.c:*")' % stap -vL 'module("amdgpu").statement("*@*execution*.c:*")' which give an impression of computed PC addresses. > It seems like something like that would reference the enclosing > section, which means we can't just leave them out of the sysfs > list... (but if such things never happen in the function-sections, > then we *can* remove them...) I'm not sure we can easily prove they can never happen there. - FChE