Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: wOoSP/RLVSVEWHG2BxbZcGETmWmpGlb/FXRmoZdH5ZHkH6KvUHtEuJ9ZyL3MoSLuFuOWO/oZuQ
 gN6MPyslrtJA==
IronPort-SDR: Z8iqhYn++WufcKhSFIRurRKwOsdQH/yF+J5w7TlJp1oymsnYKRD5uGkMvu7j8j3vG0PTbUTF1e
 xeIsCzEzBVCw==
Subject: Re: [PATCH V1 1/2] mmc: sdhci-pci-o2micro: Bug fix for O2 host
 controller Seabird1
To:     "Shirley Her (SC)" <shirley.her@bayhubtech.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20200721011733.8416-1-shirley.her@bayhubtech.com>
 <BY5PR16MB33196E3E0FB7C2143BE7D73F8B4D0@BY5PR16MB3319.namprd16.prod.outlook.com>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <fc572647-9a51-ee38-c1a7-71f62c1edad0@intel.com>
Date:   Tue, 4 Aug 2020 08:29:03 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <BY5PR16MB33196E3E0FB7C2143BE7D73F8B4D0@BY5PR16MB3319.namprd16.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sorry, I have been away for a while, but I will look at it shortly.

On 3/08/20 10:23 pm, Shirley Her (SC) wrote:
> Hi, Adrian:
> 
> Do you?have chance to review the patched code?
> 
> Thanks,
> Shirley
> 
> ----------------------------------------------------------------------------
> *From:* Shirley Her (SC) <shirley.her@bayhubtech.com>
> *Sent:* Monday, July 20, 2020 6:18 PM
> *To:* adrian.hunter@intel.com <adrian.hunter@intel.com>;
> ulf.hansson@linaro.org <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org
> <linux-mmc@vger.kernel.org>; linux-kernel@vger.kernel.org
> <linux-kernel@vger.kernel.org>
> *Cc:* Shaper Liu (WH) <shaper.liu@bayhubtech.com>; Chevron Li (WH)
> <chevron.li@bayhubtech.com>; Xiaoguang Yu (WH)
> <xiaoguang.yu@bayhubtech.com>; Max Huang (SC) <max.huang@bayhubtech.com>;
> Shirley Her (SC) <shirley.her@bayhubtech.com>
> *Subject:* [PATCH V1 1/2] mmc: sdhci-pci-o2micro: Bug fix for O2 host
> controller Seabird1
> ?
> Add bug fix for O2 host controller Seabird1
> 
> Signed-off-by: Shirley Her <shirley.her@bayhubtech.com>
> ---
> change in V1:
> 1. Add quriks2 and mmc->caps2 for Seabird1
> 2. Add get_cd support for Seabird1
> ---
> ?drivers/mmc/host/sdhci-pci-o2micro.c | 6 ++++++
> ?1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c
> b/drivers/mmc/host/sdhci-pci-o2micro.c
> index e2a846885902..ed3c605fcf0c 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -561,6 +561,12 @@ static int sdhci_pci_o2_probe_slot(struct
> sdhci_pci_slot *slot)
> ???????????????????????? slot->host->mmc_host_ops.get_cd = sdhci_o2_get_cd;
> ???????????????? }
> ?
> +?????????????? if (chip->pdev->device == PCI_DEVICE_ID_O2_SEABIRD1) {
> +?????????????????????? slot->host->mmc_host_ops.get_cd = sdhci_o2_get_cd;
> +?????????????????????? host->mmc->caps2 |= MMC_CAP2_NO_SDIO;
> +?????????????????????? host->quirks2 |= SDHCI_QUIRK2_PRESET_VALUE_BROKEN;
> +?????????????? }
> +
> ???????????????? host->mmc_host_ops.execute_tuning = sdhci_o2_execute_tuning;
> ?
> ???????????????? if (chip->pdev->device != PCI_DEVICE_ID_O2_FUJIN2)
> -- 
> 2.25.1
>