Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp72878pxa; Mon, 3 Aug 2020 23:16:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzc6wImHF/Rqi+69XCZhdcgKrshF0rKOABW4NE4ZcXp8Rjizx0pyMdNDiM9F6tkPpqRfDjF X-Received: by 2002:a17:906:3655:: with SMTP id r21mr20539767ejb.248.1596521770347; Mon, 03 Aug 2020 23:16:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596521770; cv=none; d=google.com; s=arc-20160816; b=s6YvrHkIOpq8V/TkvUE2scZ+Wa/XA6GjRNT9JpYDBFoa4UIPMGjwUl2yzGLGy5ZpvL dV0gKrbryDN7SBPEJpWDFTPVPBFSsyINqBZ3RmGHevFp7DIN+hqAOSjKfSwFozPcVlfB EAb93A0LXpOXluFFLzFvqekICGL49jX592R1jHnKFzc6s4OUXt4eWz5C2G/0AQ8e8vx3 aXk3I+ZT4IqbGFfT9cCLjeGDLb7d4yeeLb+0umaxH/uWeaQ4csMPFVbw8AtTxG1a7SaO UHytm8VLU6K0KyTb9UiIOr7kvVe42InbdLQ32rXqwOz9FkkUgvaNoVeCzVa1Vef4OX25 WS9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=Buku33lQRYbTAF0kaTgVHWdAK4J/yROeL/8VGNOmptU=; b=nWYXWvo4iQMSHD1ZVwpXn8/WMjwb1jwYOnkuMHBhFVO1PCOuwKCN6xrnlYyHj1qXR4 wOaBMgkzFqPsCQwj3tkBNwvf6lV84M183O9mgjLwRE3CjjxmUuDe3pFuvqppARpUxJ06 ZrfrYAmc5L5dl07yX4VLFyfGbbE/nKAIzD8Gm5PGKbFCt3WRrp5JyH1LNb1C8M2iju/Y s9N6kxTWxn9Fp2k6GSPZbKbBdj7BEJCnlLkn/pHlO6Vr9zH2G1J/K2P83Yu42/6R6PrI CbYsyYTKSYZpb8Y0frWcz7etuWkrz67/+ICGCVDWiPxMHVm7sPrXVwFqS4mPqcrXAczc 9jDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x25si9012865edr.231.2020.08.03.23.15.47; Mon, 03 Aug 2020 23:16:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729465AbgHDGOZ (ORCPT + 99 others); Tue, 4 Aug 2020 02:14:25 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:47747 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727076AbgHDGOY (ORCPT ); Tue, 4 Aug 2020 02:14:24 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07484;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0U4ikaQA_1596521656; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U4ikaQA_1596521656) by smtp.aliyun-inc.com(127.0.0.1); Tue, 04 Aug 2020 14:14:16 +0800 Subject: Re: [PATCH v17 00/21] per memcg lru lock To: Michal Hocko Cc: Hugh Dickins , akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com References: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> <49d4f3bf-ccce-3c97-3a4c-f5cefe2d623a@linux.alibaba.com> <08c8797d-1935-7b41-b8db-d22f054912ac@linux.alibaba.com> <20200803150704.GV5174@dhcp22.suse.cz> From: Alex Shi Message-ID: <70a88c67-d612-783b-b392-f572b7a0d4d9@linux.alibaba.com> Date: Tue, 4 Aug 2020 14:14:00 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200803150704.GV5174@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/8/3 下午11:07, Michal Hocko 写道: > On Thu 30-07-20 10:16:13, Alex Shi wrote: >> >> >> 在 2020/7/30 上午2:06, Hugh Dickins 写道: >>> On Wed, 29 Jul 2020, Alex Shi wrote: >>>> >>>> Is there any comments or suggestion for this patchset? >>>> Any hints will be very appreciated. >>> >>> Alex: it is now v5.8-rc7, obviously too late for this patchset to make >>> v5.9, so I'm currently concentrated on checking some patches headed for >>> v5.9 (and some bugfix patches of my own that I don't get time to send): >>> I'll get back to responding on lru_lock in a week or two's time. >> >> Hi Hugh, >> >> Thanks a lot for response! It's fine to wait longer. >> But thing would be more efficient if review get concentrated... >> I am still too new in mm area. > > I am sorry and owe you a review but it is hard to find time for that. > This is a large change and the review will be really far from trivial. > If this version is mostly stable then I would recommend not posting new > versions and simply remind people you expect the review from by a > targeted ping. > hi Michal, Thanks a lot for reminder! Except a update on patch [PATCH v17 18/21] mm/lru: introduce the relock_page_lruvec function from Alexander, the patchset is stable on 5.8. Just on linux-next, there are changes on hpage_nr_pages -> thp_nr_pages func name change, and lru_note_cost changes that they need a new update. And I have another 3 more patches, following this patchset which do clean up and optimzing. Is it worth for a new patchset? or let me just update here? Thanks Alex