Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [net-next v2] seg6: using DSCP of inner IPv4 packets
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        andrea.mayer@uniroma2.it
References: <20200803181417.1320-1-ahabdels@gmail.com>
 <20200803124817.5068e06d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From:   Ahmed Abdelsalam <ahabdels@gmail.com>
Message-ID: <01738166-f784-09f3-2286-150442ffa237@gmail.com>
Date:   Tue, 4 Aug 2020 09:42:07 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200803124817.5068e06d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

The problem was the declaration of tos.
Fixed and new patch is sent.

On 03/08/2020 21:48, Jakub Kicinski wrote:
> On Mon,  3 Aug 2020 18:14:17 +0000 Ahmed Abdelsalam wrote:
>> This patch allows copying the DSCP from inner IPv4 header to the
>> outer IPv6 header, when doing SRv6 Encapsulation.
>>
>> This allows forwarding packet across the SRv6 fabric based on their
>> original traffic class.
>>
>> Signed-off-by: Ahmed Abdelsalam <ahabdels@gmail.com>
> 
> Please make sure it builds cleanly with W=1 C=1:
> 
> net/ipv6/seg6_iptunnel.c:131:21: warning: incorrect type in assignment (different base types)
> net/ipv6/seg6_iptunnel.c:131:21:    expected restricted __be32 [usertype] tos
> net/ipv6/seg6_iptunnel.c:131:21:    got unsigned char
> net/ipv6/seg6_iptunnel.c:133:21: warning: incorrect type in assignment (different base types)
> net/ipv6/seg6_iptunnel.c:133:21:    expected restricted __be32 [usertype] tos
> net/ipv6/seg6_iptunnel.c:133:21:    got unsigned char [usertype] tos
> net/ipv6/seg6_iptunnel.c:144:27: warning: incorrect type in argument 2 (different base types)
> net/ipv6/seg6_iptunnel.c:144:27:    expected unsigned int tclass
> net/ipv6/seg6_iptunnel.c:144:27:    got restricted __be32 [usertype] tos
>