Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: LynoaAj2tJ0Qaaa4eQddhXwvgntnMdcz2CVPrdae9XW35400pULLYDgm176byLR5YE/TLVN3Bg
 Rts+DDRgOpYw==
IronPort-SDR: YF9oO/DawN+7bgLS7A4hJFZSDGF0+0HcjlrlB5v2RNEi9n5p6xZqiRiBl31h4V/Ye3UdYO6ff6
 /webKnV6QCTw==
Date:   Tue, 4 Aug 2020 11:14:59 +0300
From:   Sakari Ailus <sakari.ailus@linux.intel.com>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc:     Jacopo Mondi <jacopo@jmondi.org>,
        Steve Longerbeam <slongerbeam@gmail.com>,
        Hugues Fruchet <hugues.fruchet@st.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Prabhakar <prabhakar.csengg@gmail.com>,
        linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: media: i2c: ov5640: Document
 bus-type property
Message-ID: <20200804081458.GC13316@paasikivi.fi.intel.com>
References: <1596465107-14251-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <1596465107-14251-2-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1596465107-14251-2-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Prabhakar,

Thanks for the update.

On Mon, Aug 03, 2020 at 03:31:44PM +0100, Lad Prabhakar wrote:
> Document the possible bus-type's supported by the OV5640 sensor driver.
> 
> Also add the bus-type in example node.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/media/i2c/ov5640.txt | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.txt b/Documentation/devicetree/bindings/media/i2c/ov5640.txt
> index c97c2f2da12d..00131dbb147e 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov5640.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.txt
> @@ -36,9 +36,15 @@ Endpoint node required properties for parallel connection are:
>  - data-shift: shall be set to <2> for 8 bits parallel bus
>  	      (lines 9:2 are used) or <0> for 10 bits parallel bus
>  - hsync-active: active state of the HSYNC signal, 0/1 for LOW/HIGH respectively.
> +		(Required for bus-type 5)
>  - vsync-active: active state of the VSYNC signal, 0/1 for LOW/HIGH respectively.
> +		(Required for bus-type 5)
>  - pclk-sample: sample data on rising (1) or falling (0) edge of the pixel clock
> -	       signal.
> +	       signal. (Required for bus-type 5)
> +- bus-type: data bus type. Possible values are:
> +	    4 - MIPI CSI-2 D-PHY
> +	    5 - Parallel
> +	    6 - Bt.656

This is under required parallel properties. You could document value 4
under CSI-2 related properties.

>  
>  Examples:
>  
> @@ -86,6 +92,7 @@ Examples:
>  				hsync-active = <0>;
>  				vsync-active = <0>;
>  				pclk-sample = <1>;
> +				bus-type = <5>;
>  			};
>  		};
>  	};

-- 
Regards,

Sakari Ailus