Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp162882pxa; Tue, 4 Aug 2020 02:18:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4PHBzmxH8QtgF7sstbTa0AjsRnZFT/sNofV/fMYBSMNCai5zMXiqXdP42ccK91aYbKMhF X-Received: by 2002:a05:6402:1e2:: with SMTP id i2mr19014578edy.70.1596532737350; Tue, 04 Aug 2020 02:18:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596532737; cv=none; d=google.com; s=arc-20160816; b=zQeWzdf6VplJ0mwRCjwTB1CX0f9ERpdhD7nwWZfUDQIhtP1QpIGJ05cdqOhKUfwZjQ t43zN+Gwu0PUaj2+F9YIOfKvh+qip8s1LIcLGdX4IQ7YA1tDMnegV4bQi6ACYYTyb5Ya ohKAWOQiBmesoYwdunPcfIRpWVVzYYWs4YKyxIGtlsJyMmHxusAFLUvQXUG72M+0DpkK 07d5gCCRiVy/09XPGmsGMQvQ5ivXQabt2igWiEVpfNyJRHT8lTDiIUuAkGmmPYqV9Bcd YZzstjwrCPIDU6fZp2pOmavo/AfL2onKKXVtQ9XoJnDyHIsIzZ1E1EvzMwkx/RSQ370O mhyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=P91q9lMxYYepCGCawQXctb/Y4F2Hm5o6hBEWXcqce3M=; b=e98teyIuq/4cUs4oz5OBMxVmgWw8V1FZhqxKWk9rXits8kuIhcBhHoq4INcGu8R8zD c4FQh7abwZ6s+2gP1VyBqoHL6MbDQUDh3R7vczQms6tYi8UDUDNKi1WlZyJ3NebcEGDQ OFo+bLqgLfeEP8A/qag37YONfACwi9Kv/mWKLI2s4Qj9Qf5JtiLvhcm1V6aU0bcaxp6t mCyHJR3zJG4FUGbjh+476/i8L/eVReFc8Ja/tZUjPQLqBRjmpmERZUQrM1Zn4Sw0ZbnU Vw1+3Uw5nyEM5Rf2KZ4xJuaRZGB2NRJnbOxeOKKJ5o5hT04TnUUKPb/Bi46ohkJ2hZzq PczQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si9066135edv.411.2020.08.04.02.18.34; Tue, 04 Aug 2020 02:18:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729936AbgHDJRl (ORCPT + 99 others); Tue, 4 Aug 2020 05:17:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:40006 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726056AbgHDJRl (ORCPT ); Tue, 4 Aug 2020 05:17:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D7F87AD25; Tue, 4 Aug 2020 09:17:55 +0000 (UTC) Message-ID: <1596532658.19923.6.camel@suse.com> Subject: Re: [PATCH] cdc-acm: rework notification_buffer resizing From: Oliver Neukum To: trix@redhat.com, gregkh@linuxfoundation.org, t-herzog@gmx.de Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 04 Aug 2020 11:17:38 +0200 In-Reply-To: <20200801152154.20683-1-trix@redhat.com> References: <20200801152154.20683-1-trix@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Samstag, den 01.08.2020, 08:21 -0700 schrieb trix@redhat.com: > From: Tom Rix > > Clang static analysis reports this error > > cdc-acm.c:409:3: warning: Use of memory after it is freed > acm_process_notification(acm, (unsigned char *)dr); > > There are three problems, the first one is that dr is not reset Hi, thank you, good catch. Regards Oliver