Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 4 Aug 2020 11:20:25 +0100
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     Jason Liu <jason.hui.liu@nxp.com>
Cc:     will@kernel.org, catalin.marinas@arm.com, ashal@kernel.org,
        maz@kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it
 already masked
Message-ID: <20200804102025.GA15199@bogus>
References: <20200804085657.10776-1-jason.hui.liu@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200804085657.10776-1-jason.hui.liu@nxp.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

+Marc Z

On Tue, Aug 04, 2020 at 04:56:57PM +0800, Jason Liu wrote:
> No need to do the irq_chip->irq_mask() if it already masked.
> BTW, unconditionally do the irq_chip->irq_mask() will also bring issues
> when the irq_chip in the runtime PM suspend. Accessing registers of the
> irq_chip will bring in the exceptions. For example on the i.MX:
>

The change looks good and is inline with the additional checks we do for
eoi and disable. However, the imx_irqsteer_irq_mask is not safe to be
called with runtime suspend. What happens if some driver using the irq
on this chip calls disable_irq when this irqchip is suspended ?

-- 
Regards,
Sudeep