Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 4 Aug 2020 13:49:51 +0200
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled
Message-ID: <20200804114951.ijs3hnezi4f64nll@function>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
        speakup@linux-speakup.org
References: <20200804111332.dex7jobmabifdzw5@function>
 <20200804113413.GA181242@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200804113413.GA181242@kroah.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Greg KH, le mar. 04 août 2020 13:34:13 +0200, a ecrit:
> On Tue, Aug 04, 2020 at 01:13:32PM +0200, Samuel Thibault wrote:
> > Drivers using serialio are already made available in Kconfig only under
> > the ISA condition.
> > 
> > This solves warnings in inb/outb macros on platform that do not have 
> > support for ISA.
> > 
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > 
> > Index: linux-2.6/drivers/accessibility/speakup/Makefile
> > ===================================================================
> > --- linux-2.6.orig/drivers/accessibility/speakup/Makefile
> > +++ linux-2.6/drivers/accessibility/speakup/Makefile
> > @@ -16,6 +16,7 @@ obj-$(CONFIG_SPEAKUP_SYNTH_TXPRT) += spe
> >  obj-$(CONFIG_SPEAKUP_SYNTH_DUMMY) += speakup_dummy.o
> >  
> >  obj-$(CONFIG_SPEAKUP) += speakup.o
> > +obj-$(CONFIG_ISA) += serialio.o
> >  speakup-y := \
> >  	buffers.o \
> >  	devsynth.o \
> > @@ -25,7 +26,6 @@ speakup-y := \
> >  	keyhelp.o \
> >  	kobjects.o \
> >  	selection.o \
> > -	serialio.o \
> >  	spk_ttyio.o \
> >  	synth.o \
> >  	thread.o \
> 
> Oops, no, I get the following build errors with this patch:
> 
> ERROR: modpost: "spk_wait_for_xmitr" [drivers/accessibility/speakup/speakup.ko] undefined!

Yes, it depends on the first of the queue.

Samuel