Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp339989pxa; Tue, 4 Aug 2020 06:59:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzefERXPvfsHSP3QiyFm13SZgA4StOtqkjFkiFboWL/kPQ7sU2Jqc2YICJQRWXLQDokzHGD X-Received: by 2002:a17:906:3b01:: with SMTP id g1mr22635158ejf.353.1596549585837; Tue, 04 Aug 2020 06:59:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596549585; cv=none; d=google.com; s=arc-20160816; b=A7bx8KTpWRhLcmFsGGE8pZ2NDc05iOPlCenIbdfYbhWg2FZAqc9HPFmxg2HP65SX9j 5cuyeu5bjGZYagvYZBgKZ/iRJZfpoH4lfR8CBgpKRJN2aRGIe20pUkaCQWtoJIJeu+i4 HHBIO6eOs+AR/hytKlR/1Tnhp0d+bG9DchMLh/5k3ytXJVkn7DU7RUrf2Pr6PI+C401m tF+XA7591dsTCd6LpucA7cbc8tgLLUpfNKmMONq6nM/Wbo6DvpZIPjvbOQe1kNhDbnW0 AKiPGJu/3Ylksmtql6j4v2rjbndKZh0X3U7ZIU3y8+Le4krHbCPl84r5LcT54OpfZqnB b8hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Nir289YmvLvB9cYHD+WrMlDkgzY7IXddotY7RZ5kJuw=; b=gIR1YBArTODt6x9WJN3l8Bi+WghHX9LfcdqiRr3Lkyi1XhXnXl0oLCsVnzs8pa8Tqo QoCchrzwIBPehf7Mx4FPhnNeL7uR94ItsgRTe9FshEpDwPKp7RYpHSLIXH/ty38HUJl0 3SgF8AI3RL/JlZ52l90+vAoHfk40ZZ2F654Z5eNZCVx4LqP1B+kW4SqCZXO7YauuPbO2 66wjh0inQCVaQMfDBF3AYzMMmuLQ+P+Ec7JAOZSNn4R6oqoaNn1unEa6e4hf69MBLAEg 1Tu5P+jX0KwSapYVQ9VvgDNubn4kp9Za9AtycxSX84kDvzwFkPsitEqDqLRnfGlurjre fMcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=AEHps8rn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d23si5435089edr.58.2020.08.04.06.59.12; Tue, 04 Aug 2020 06:59:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=AEHps8rn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728668AbgHDN45 (ORCPT + 99 others); Tue, 4 Aug 2020 09:56:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728535AbgHDN4q (ORCPT ); Tue, 4 Aug 2020 09:56:46 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB0B9C061757 for ; Tue, 4 Aug 2020 06:56:45 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id d6so28676133ejr.5 for ; Tue, 04 Aug 2020 06:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Nir289YmvLvB9cYHD+WrMlDkgzY7IXddotY7RZ5kJuw=; b=AEHps8rnJNYWjEsEPmsNrngg9TrZ3KWI5HcB4+HHRs9di0+/ESZLPa6/JKEXxXRDtU j0ZA7GgeP7mT12IX5LxV4n0BWV70/alU7ADPeaFlcj67EWL5F74zxF5tjSOVXXhgCu3N g/f2upIq2fhT1dR8LKBd75so90/Gkfjyd4Eik= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Nir289YmvLvB9cYHD+WrMlDkgzY7IXddotY7RZ5kJuw=; b=VduLHr+TDECg1xrzPyt+hlZeYkgAncROIgyE83mr6AuJ0U/g6DG4rleMGi4MCTTzXx HNiM43p1klcmeVkCX3fBC4ztiBrKatk/zpx1J/wzDfIZ6xUh4xxHpVm0Ut46H75HeNnr NOeZGu6hMUeqNLDl5vO8WX2CzDxKzZI9MytfqUppJv8ZrcNIerZfO1OpbVniLaaENBQp h7Q16isRtxFR8SSYkf/TsoBBll4OYznq4FNVzzzNm/26YDKZXldQgVZ4l/78PRtoDaCC 5/S2Tw+LThcVIZdiXA9DX6GYllOBAFSYGU+GgpqdunneF2NlA+U7QtYN7kxaiiCl+9VS 2mLg== X-Gm-Message-State: AOAM530c5vQhXkFqKqxUVTxmgRglMYZ3PGrudZlokDJplZlipEN3sYm4 diHLlwa+VEPqly8FRuG0exdhRg== X-Received: by 2002:a17:906:f905:: with SMTP id lc5mr20891718ejb.340.1596549404630; Tue, 04 Aug 2020 06:56:44 -0700 (PDT) Received: from miu.piliscsaba.redhat.com (catv-212-96-48-140.catv.broadband.hu. [212.96.48.140]) by smtp.gmail.com with ESMTPSA id 4sm18404381ejn.84.2020.08.04.06.56.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 06:56:44 -0700 (PDT) Date: Tue, 4 Aug 2020 15:56:41 +0200 From: Miklos Szeredi To: David Howells Cc: viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, raven@themaw.net, mszeredi@redhat.com, christian@brauner.io, jannh@google.com, darrick.wong@oracle.com, kzak@redhat.com, jlayton@redhat.com, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/18] fsinfo: Provide notification overrun handling support [ver #21] Message-ID: <20200804135641.GE32719@miu.piliscsaba.redhat.com> References: <159646178122.1784947.11705396571718464082.stgit@warthog.procyon.org.uk> <159646187082.1784947.4293611877413578847.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159646187082.1784947.4293611877413578847.stgit@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 03, 2020 at 02:37:50PM +0100, David Howells wrote: > Provide support for the handling of an overrun in a watch queue. In the > event that an overrun occurs, the watcher needs to be able to find out what > it was that they missed. To this end, previous patches added event > counters to struct mount. So this is optimizing the buffer overrun case? Shoun't we just make sure that the likelyhood of overruns is low and if it happens, just reinitialize everthing from scratch (shouldn't be *that* expensive). Trying to find out what was missed seems like just adding complexity for no good reason.