Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp623073pxa; Tue, 4 Aug 2020 13:50:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxCUyOkQFNyS0BvswhJmObWwznpj5eGzLSMpjRXT2KlK56H1R+ZzPGj3TxLOfRUySWMMyT X-Received: by 2002:a17:906:7790:: with SMTP id s16mr16524907ejm.254.1596574242419; Tue, 04 Aug 2020 13:50:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596574242; cv=none; d=google.com; s=arc-20160816; b=O8gvGNl5FIpuivmccLSi3jSAvvDwK9gzZfIe8bCJi998EVPnlH+hX/zN3MyLbVIljw ObAj7HDD4aYRoUa5T5/REnuJ8TBeW5YHX8S7zmJIVCtZNNw/WktnevBd7b0adUoFMfyT tT4vgS6zFtkXFAp4TB34FrIinu7Ye/wXocoh4BiG0eT1Ye4h2mOi7fgvA7i5T4NAaZfp m/VnVec4AopIW3SJDH+0oRbxeN50FOopWfQwzE4U3kuYDdDyDsIqR4lFbOU2LpWNXaLC CRaUJ2bKKUB1jYOuYTES6m5Klo9gdL1DXDiApXNY/5u0cRGfNwwRty5ozUBY82P+ZOV1 iQJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=NqpbOQVzDCzUgU0urNu9EPIE4Ge9MLfqzEnXxyaLaK0=; b=IfN9jIL+dcRBPVOPb2UCp7HR/AUG7qcA/hxJppOvijgUBErkjQbakO1pYXuEVgmdu4 vb1lCqjhUWTiV7jf5xtq1ISNQxrwRU9x7hGkVHeKQZXA1VGsa5kGY9JpeKwQpkbfh5lx Fou3hx9kg6LBhlFzsvIJ89oB1fOkdVXTapja/8eloNx/95gAw6YxQ+VGhYdF0lm/yNxP 8TPvVQ0DAamBy0diPU8AqlIzf+Wb4H7gpvfwhdd6VpMm/ntDL1xGHc/kv2YROf9C2R55 VZTNVLd5JSjhNZk8sfT0lDk8NIgvri8ttEHL5pt5Jflpp1m0+JQhIgrriJDSFs6DZosN M74A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vSmsvJyS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x18si13926176ejd.51.2020.08.04.13.50.01; Tue, 04 Aug 2020 13:50:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vSmsvJyS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728231AbgHDUs3 (ORCPT + 99 others); Tue, 4 Aug 2020 16:48:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727057AbgHDUs2 (ORCPT ); Tue, 4 Aug 2020 16:48:28 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89DE3C06174A for ; Tue, 4 Aug 2020 13:48:28 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id m22so860578eje.10 for ; Tue, 04 Aug 2020 13:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NqpbOQVzDCzUgU0urNu9EPIE4Ge9MLfqzEnXxyaLaK0=; b=vSmsvJySEicOLbSHzIA6J7MgSzVb0wwZnrCz69Ozrzro7d3Ac1yqFZH0FAfB73KIwY 8JYwmoBy0NZVisqeb84sLLG/CkCrIjrwrM1XE4HolDbRdylLOvRrwDKWgx8qGEzEJCX7 zppNPDwiytYQmvHetDGpoJBMfqCPpoxdG9YtpEesl8rGln7bjGSWl9OOJnxr81w5/GNj QTUhiusCCh6y1z8gksTYZi5Vl2onOiiaMGavWoSA8LmVVgXrkBQKiHHEZQ2sujUoGs0w /4Ix6WtmX4toYoHqZFEFmBgBYybhz8y/7cQqkah6j200r92kY8kaRy5dlF0SEBcW42Rf TI4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NqpbOQVzDCzUgU0urNu9EPIE4Ge9MLfqzEnXxyaLaK0=; b=Omm9CaNnnr5gDOjQSqFSCsDiPYHtAm+NqNvXgDcCDYPC0ZYX1JcOeWtEmiksEZAXNH 166+OFaTMuv+A8dlEYVO8YL+jN4lhEfzLeMlYGATb8XJpQpPkgd2cpfkUO/rkidcgHv/ J2YUATgy3c8KZDTckbgF0CE7j24KlKSHfkHMAwWvAT8CRSMtJuiA3btjVsftAfyX1YIM jS856csdH8OiP4c9S0aEThGGaoRaZ8P4SVxF/yLoBhDksYi66QPkzhEX6sVGXjtLiJxN Dbw2peUEO19FhDEv1GhwUVMdoVp76P7Gbfi0LMlPis5FGJ2nZYOwZMIboRragqCWL7zs uZeQ== X-Gm-Message-State: AOAM533yMlIiKY1KubvhxtxvD36SHyrt9LL9kYoguslq3o4OD4PYE7ff O3AKQ08IjbshpXfkT0kUOWw= X-Received: by 2002:a17:906:1392:: with SMTP id f18mr22686757ejc.521.1596574107347; Tue, 04 Aug 2020 13:48:27 -0700 (PDT) Received: from ltop.local ([2a02:a03f:a7fb:e200:d068:a44f:fa3b:62da]) by smtp.gmail.com with ESMTPSA id di5sm78772edb.16.2020.08.04.13.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 13:48:24 -0700 (PDT) Date: Tue, 4 Aug 2020 22:48:08 +0200 From: Luc Van Oostenryck To: Stafford Horne Cc: LKML , Linus Torvalds , Jonas Bonn , Stefan Kristiansson , openrisc@lists.librecores.org Subject: Re: [PATCH 3/6] openrisc: uaccess: Use static inline function in access_ok Message-ID: <20200804204808.ttgkwrievzn5aoqd@ltop.local> References: <20200804042354.3930694-1-shorne@gmail.com> <20200804042354.3930694-4-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200804042354.3930694-4-shorne@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 04, 2020 at 01:23:51PM +0900, Stafford Horne wrote: > As suggested by Linus when reviewing commit 9cb2feb4d21d > ("arch/openrisc: Fix issues with access_ok()") last year; making > __range_ok an inline function also fixes the used twice issue that the > commit was fixing. I agree it's a good cleanup. This patch addresses > that as I am currently working on the access_ok macro to fixup sparse > annotations in OpenRISC. > > Suggested-by: Linus Torvalds > Signed-off-by: Stafford Horne Look good to me. -- Luc