To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 21 of 53] ipath - use phys_to_virt instead of bus_to_virt
References: <4e0a07d20868c6c4f038.1147477386@eng-12.pathscale.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Mon, 15 May 2006 08:50:27 -0700
In-Reply-To: <4e0a07d20868c6c4f038.1147477386@eng-12.pathscale.com> (Bryan O'Sullivan's message of "Fri, 12 May 2006 16:43:06 -0700")
Message-ID: <adad5efuw1o.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 631
Lines: 16

 > I think Roland already has this patch.

 >  	 * This is a bit of a hack since we rely on dma_map_single()
 > -	 * being reversible by calling bus_to_virt().
 > +	 * being reversible by calling phys_to_virt().

Actually I NAK'ed this patch.  It compiles the same thing on x86_64
but makes the source code wrong -- dma_map_single() returns a bus
address, not a physical address.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/