To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 41 of 53] ipath - disable interrupts while holding spinlock in RWQE get
References: <83f1832c601594846868.1147477406@eng-12.pathscale.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Mon, 15 May 2006 08:55:37 -0700
In-Reply-To: <83f1832c601594846868.1147477406@eng-12.pathscale.com> (Bryan O'Sullivan's message of "Fri, 12 May 2006 16:43:26 -0700")
Message-ID: <ada4pzruvt2.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 920
Lines: 23

 > @@ -171,12 +171,13 @@ int ipath_get_rwqe(struct ipath_qp *qp, 
 >  			n = rq->head - rq->tail;
 >  		if (n < srq->limit) {
 >  			srq->limit = 0;
 > -			spin_unlock(&rq->lock);
 > +			spin_unlock_irqrestore(&rq->lock, flags);
 >  			ev.device = qp->ibqp.device;
 >  			ev.element.srq = qp->ibqp.srq;
 >  			ev.event = IB_EVENT_SRQ_LIMIT_REACHED;
 >  			srq->ibsrq.event_handler(&ev,
 >  						 srq->ibsrq.srq_context);
 > +			spin_lock_irqsave(&rq->lock, flags);

ipath_get_rwqe() in the kernel now doesn't even have a flags
variable.  So this looks like a bug introduced earlier in this patch
series.  Please roll the fix up into the place where you added the bug.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/