Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964969AbWEORCj (ORCPT ); Mon, 15 May 2006 13:02:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964974AbWEORCi (ORCPT ); Mon, 15 May 2006 13:02:38 -0400 Received: from viper.oldcity.dca.net ([216.158.38.4]:48091 "HELO viper.oldcity.dca.net") by vger.kernel.org with SMTP id S964969AbWEORCh (ORCPT ); Mon, 15 May 2006 13:02:37 -0400 Subject: Re: [PATCH 4/6] myri10ge - First half of the driver From: Lee Revell To: Brice Goglin Cc: Francois Romieu , netdev@vger.kernel.org, LKML , "Andrew J. Gallatin" In-Reply-To: <4463CE88.20301@myri.com> References: <446259A0.8050504@myri.com> <20060510231347.GC25334@electric-eye.fr.zoreil.com> <4463CE88.20301@myri.com> Content-Type: text/plain Date: Mon, 15 May 2006 13:02:34 -0400 Message-Id: <1147712555.27252.269.camel@mindpipe> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 29 On Fri, 2006-05-12 at 01:53 +0200, Brice Goglin wrote: > Francois Romieu wrote: > > > >> + spin_lock(&mgp->cmd_lock); > >> + response->result = 0xffffffff; > >> + mb(); > >> + myri10ge_pio_copy((void __iomem *) cmd_addr, buf, sizeof (*buf)); > >> + > >> + /* wait up to 2 seconds */ > >> > > > > You must not hold a spinlock for up to 2 seconds. > > > > We are working on reducing the delay to about 15ms. It only occurs when > the driver is loaded or the link brought up. I think 15ms is quite a long time to hold a spinlock also - most spinlocks in the kernel are held for less than 500 microseconds. Can't you use a mutex? Lee - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/