Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp288963pxa; Wed, 5 Aug 2020 00:51:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynHseXljer2T1dWrRpDNBO8wPjcWYGqLtp2Ix8QioHhhJWg3T5MRPFB30UZwDth2V3lzss X-Received: by 2002:a17:906:3a51:: with SMTP id a17mr1939573ejf.433.1596613880269; Wed, 05 Aug 2020 00:51:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596613880; cv=none; d=google.com; s=arc-20160816; b=rwh1F4g19kIoz/du8u3xTwQ4xEqQylv1kC+g7SQoC7EJbMs4I9cLWBGlZt4SYRMrdP S2UXo9itU2rKjgiwX4bZ1SYsG6B+Y8ey2kVMTArxg1jEn04Xq0fOfCFPO+UQo49jly/t I10Y1UBmDBVSUgZpWdeeuDy5uXXHPTAkZegK+wkD7P1AVo2XL/Smjy5rNcekZeHkgT9o JSIamNT2iJlG6DHSj3Qj1bUDTEI+71ytRV6DDos69dK1uHGcFqjdyALPYqipL6yqlTrL vfx/WE6DOAaesWohVejgpfpIL3/FpTtxsNDDfiloowVspAu5Q/arBqZ1Lg0a0NKDy3le 442g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=LRtKXBpjEZU1Szq2/gwLOhv7+TuRReJ9VxeGEyJMkAM=; b=idyZBse2qrnX4T4wnJOlmzW3/kuyB+hyhfBsTtXdJ98PbhpCD6ZBnHdkrsDjSWdgo8 QIV3W1JcWSPtl6wySo255W7E5wcOR61ZomW7SDN9YCDOYxj9ZqTTl9SCSXLqN9wE3lfY /UPc8vMqxN8YqI6DUrv8if+oKK0/pMIAjsjaTt5JB+X8UmpJW1UROIP+fKgdAbhGPU9g rnEQn0pvsl10bJaNrI3G62ujSfSDUsjAj74sheBoEbiZ8AeZmAJz30caWvQf9H7Bpdui Fe9OB2FTUNHClYu3VoRw4T0A39awwmSu8nEDSGekh4q6LWiVkuY2JMlxW21xD2S7YgTK jchw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x60si871324ede.582.2020.08.05.00.50.58; Wed, 05 Aug 2020 00:51:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727801AbgHEHuq (ORCPT + 99 others); Wed, 5 Aug 2020 03:50:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbgHEHun (ORCPT ); Wed, 5 Aug 2020 03:50:43 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C4A0C061756 for ; Wed, 5 Aug 2020 00:50:42 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3EC7-0003wV-G7; Wed, 05 Aug 2020 09:50:39 +0200 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1k3EC7-0007Z0-5j; Wed, 05 Aug 2020 09:50:39 +0200 Date: Wed, 5 Aug 2020 09:50:39 +0200 From: Marco Felsch To: Adam Ford Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: ili210x: Fix potential memory leaks Message-ID: <20200805075039.jptytefw3mm2d4nq@pengutronix.de> References: <20200804183007.117125-1-aford173@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200804183007.117125-1-aford173@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:48:37 up 263 days, 23:07, 241 users, load average: 0.14, 0.10, 0.05 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Adam, On 20-08-04 13:30, Adam Ford wrote: > This driver requests, memory twice and requests a threaded irq, but > it doesn't free any of them if something fails. Free'ing is done automatically because the driver uses devres (identified by devm_ prepfix) functions. Regards, Marco