Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp289769pxa; Wed, 5 Aug 2020 00:53:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwnJ3MOQGouKc/SVCqnbvH4OZMSLS9Z9hKCLOxbn9bxDy7tRBgPgmFekuh5seB6j2Tb437 X-Received: by 2002:a05:6402:21d3:: with SMTP id bi19mr1692122edb.56.1596613997048; Wed, 05 Aug 2020 00:53:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596613997; cv=none; d=google.com; s=arc-20160816; b=H/SLRTtGKmPSFOFmiqzrSz4sbpQ5t5olIviUtJ5y6slizirTWtKpYAEQqBRX2L+Fga JOl/zC0hZqW9T4/4hyEClmft2b4f5ta0CE8Ug7o7PJZvgs2XFaAHf5d7+5wdEmMxtyzM j8TkPF8O31AehBsOSztkPL0JLhf1CMMpeSKeO1k+tBOgST7s7BpY4GKJ2fAP4x5hBTEN JAqN5F/n55xut+otnb4PYcvsHGetNjo1LqSOubiJ/nMdcow9ZEAOA371xOdpR/InX1fA jj5jTEn/wo64dVAdxMy4YntjnXg9xi1pX7q0g+Iz6MsokB8qiuuMeaYeySGOUm+wDnS+ cCug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:message-id:date:subject:cc:to:from; bh=H2sbJQmMcWD6/zfAOJ207RVzT1WoIQcX4GSPnARgAN0=; b=rmz+t4vvBZ4IsWHvFJkpBBwu0vgSH1NzJqfg7NETdTldwNMYQP70v3ir5lZ2M30YtZ enFLOjwWe5jYW3Pa81iiHjSDCjNTgcWXAgO6j8GXdIQRr/b4FV9bdAe0Dv6w5pgOxfhA 4SKPvYF5lTBlSjaujY35kKzyg8QuSdCgZKSEnRKyICVPY3L/ormv6uyYJAOGVW/XZnQB RONZ1KbL58Sqp7Hg02q2Lrc5FnqORD1yHiCsBlDA9WbGgMHEYIhjOCi+6HSAbpYge34W 0BUFFH48ZQk/hwm7SDc5st1ULhbK/3uu/5kWpwO8cRAYSaDCm6FJlxkKW4mMOcTB085k 0oAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e6si947006edv.187.2020.08.05.00.52.54; Wed, 05 Aug 2020 00:53:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726524AbgHEHw3 convert rfc822-to-8bit (ORCPT + 99 others); Wed, 5 Aug 2020 03:52:29 -0400 Received: from mx1.emlix.com ([188.40.240.192]:45480 "EHLO mx1.emlix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbgHEHw2 (ORCPT ); Wed, 5 Aug 2020 03:52:28 -0400 Received: from mailer.emlix.com (unknown [81.20.119.6]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 818925FCA2; Wed, 5 Aug 2020 09:52:25 +0200 (CEST) From: Rolf Eike Beer To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ralf Baechle , Paul Burton , Alexander Viro Subject: [PATCH] binfmt_elf: fix documented return value for load_elf_phdrs() Date: Wed, 05 Aug 2020 09:52:23 +0200 Message-ID: <6469675.ETGqQKjL3G@devpool35> Organization: emlix GmbH MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This function has never returned anything but a plain NULL. Fixes: 6a8d38945cf4e6e819d6b550250615db763065a0 Signed-off-by: Rolf Eike Beer --- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 9fe3b51c116a..251298d25c8c 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -428,7 +428,7 @@ static int elf_read(struct file *file, void *buf, size_t len, loff_t pos) * * Loads ELF program headers from the binary file elf_file, which has the ELF * header pointed to by elf_ex, into a newly allocated array. The caller is - * responsible for freeing the allocated data. Returns an ERR_PTR upon failure. + * responsible for freeing the allocated data. Returns NULL upon failure. */ static struct elf_phdr *load_elf_phdrs(const struct elfhdr *elf_ex, struct file *elf_file) -- 2.28.0 -- Rolf Eike Beer, emlix GmbH, http://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 Göttingen, Germany Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160 Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055 emlix - smart embedded open source