Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp291528pxa; Wed, 5 Aug 2020 00:57:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCHw1/Rg+esH9MTKdH0TUUW/EMKIWNDRrGRakvDjBYCP4FLARrqYXkPBGlcZDJ1XweX56H X-Received: by 2002:a50:9fc9:: with SMTP id c67mr1668602edf.69.1596614263723; Wed, 05 Aug 2020 00:57:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596614263; cv=none; d=google.com; s=arc-20160816; b=aNLe1oOzDC941EZa46xXAV1q2UouZQ+bNQBpNVlm5kTEgMTn6zwu6xhP+LQGX7PK3f HR/EkFO+HEUTJR+lpTafqqJnxZ7Epc8OnYq+Bvy7DR5L1+rtm2uKAV0xbTgj6W7jJjV/ Q2Hsw7gd280n/NUFqxSL1tMSGu1PhCeiozcCM48/9JJptBseMD0T7LDlljWIJy9BgRsw iAqaKg56H3U04XwerQqC1IxFcFFhGXHUld/9iVyHtWqRR1r1DBDXBseICcDw0nRsh+xl optCQnoWAbX7bBYztncEppr2XvGeNTjydp5rNQicR8inAbMNjVgXXPL49GEMuZs8gj8o GGqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=rOO6ShHpp5UGNOPznCdecSzGakQjRzipAf82VmDBvJI=; b=T8dwnj+IaLS3VjnYZWs+8fHk5lUA9tK1SmTlBhT9ald8qVaw38dERymCMauluWutWA 5P2dsGa4bQYYeYIHycmKrsYEvHFuuHSw7rVKCs8yO2eih3qeOCDgZnYnBK9ORLp+ZDzY vJnipZxdE6VmIYThiEzfh51dw9qjMYY4IHPT8z+9Z8uT8QoCP0lML5QYmoXmB3K+Ikww 53hoN9HP4Qg7308BfbJp6fa5j/4OIMb1zDN70FIvgWULUnOzZ1c+mMU8MdW6EJHr2+rs KbDa4oMv2/+QBndzyJOgqedJ5FTRdGWIss5ibMXSUganXvg+2zyn6fU7Pce5fYidTtMF Eg7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="TQ3t3d/V"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q24si780380eds.349.2020.08.05.00.57.20; Wed, 05 Aug 2020 00:57:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="TQ3t3d/V"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727867AbgHEH5C (ORCPT + 99 others); Wed, 5 Aug 2020 03:57:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:57448 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbgHEH47 (ORCPT ); Wed, 5 Aug 2020 03:56:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FA4321744; Wed, 5 Aug 2020 07:56:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596614219; bh=w7tzLksrCv4ALQStcKSfize2/X8xdy7tmJu6ujP5RS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TQ3t3d/V6OFAF4jjvStcD4uckOm0QSQoQ0ILHB90Xk0i2BlpAETwThQixlfZIKjpG dPmkatHTgnaOnRkwxjpJjemVuyScuS5NKc4zmucMOXgjQPb3jOvZRO2rBLJWk+kGYR XH/OAyMyv883UUdN7M5GPzQ8WCaJHVjxVtOp38fM= Date: Wed, 5 Aug 2020 09:57:17 +0200 From: Greg KH To: Dongdong Yang Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, devel@driverdev.osuosl.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, yangdongdong@xiaomi.com, yanziily@xiaomi.com, rocking@linux.alibaba.com Subject: Re: [PATCH v5] sched: Provide USF for the portable equipment. Message-ID: <20200805075717.GB635696@kroah.com> References: <3bbd9a487176a05588e33ff660d4e58efa1fdb10.1596612536.git.yangdongdong@xiaomi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3bbd9a487176a05588e33ff660d4e58efa1fdb10.1596612536.git.yangdongdong@xiaomi.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2020 at 03:36:21PM +0800, Dongdong Yang wrote: > +#define usf_attr_rw(_name) \ > +static struct device_attribute _name = \ > +__ATTR_RW(_name) I also asked you to use DEVICE_ATTR_RW() and not use "raw" kobjects. Why you ignore code review is odd... greg k-h