Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 5 Aug 2020 09:47:57 +0100
From:   Sudeep Holla <sudeep.holla@arm.com>
To:     Jason Liu <jason.hui.liu@nxp.com>
Cc:     Marc Zyngier <maz@kernel.org>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        "sashal@kernel.org" <sashal@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it
 already masked
Message-ID: <20200805084748.GA4818@bogus>
References: <20200804085657.10776-1-jason.hui.liu@nxp.com>
 <b4444c737f9d6fd8fd99dbb809d35a0f@kernel.org>
 <20200804113850.GB15199@bogus>
 <VI1PR0402MB38243230C51FDB1C3F490853AE4B0@VI1PR0402MB3824.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <VI1PR0402MB38243230C51FDB1C3F490853AE4B0@VI1PR0402MB3824.eurprd04.prod.outlook.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 05, 2020 at 06:31:20AM +0000, Jason Liu wrote:
> >
> > Indeed, the runtime PM ops in that driver looks dodgy. Any calls to mask_irq
> > from drivers or anywhere with irqchip suspended with just blows up the
> > system.
>
> If you look at the chip->irq_mask implementation on different platforms, almost
> all with directly access the register of the irqchip including irqsteer.
> There are fine due to driver will use the common mask_irq API.
>

That still doesn't explain how you can prevent system from blowing up if
chip->irq_mask gets called with irqchip suspended ?

--
Regards,
Sudeep