Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <62165f6af630ec134713a7fa2c136ec60a67d2f2.camel@redhat.com>
Subject: Re: [PATCH] net: openvswitch: silence suspicious RCU usage warning
From:   Paolo Abeni <pabeni@redhat.com>
To:     xiangxia.m.yue@gmail.com, davem@davemloft.net, echaudro@redhat.com,
        kuba@kernel.org, pshelar@ovn.org, syzkaller-bugs@googlegroups.com
Cc:     dev@openvswitch.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Date:   Wed, 05 Aug 2020 11:00:37 +0200
In-Reply-To: <20200805071911.64101-1-xiangxia.m.yue@gmail.com>
References: <20200805071911.64101-1-xiangxia.m.yue@gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4 (3.36.4-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-08-05 at 15:19 +0800, xiangxia.m.yue@gmail.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> 
> ovs_flow_tbl_destroy always is called from RCU callback
> or error path. It is no need to check if rcu_read_lock
> or lockdep_ovsl_is_held was held.
> 
> ovs_dp_cmd_fill_info always is called with ovs_mutex,
> So use the rcu_dereference_ovsl instead of rcu_dereference
> in ovs_flow_tbl_masks_cache_size.
> 
> Fixes: 9bf24f594c6a ("net: openvswitch: make masks cache size configurable")
> Cc: Eelco Chaudron <echaudro@redhat.com>
> Reported-by: syzbot+c0eb9e7cdde04e4eb4be@syzkaller.appspotmail.com
> Reported-by: syzbot+f612c02823acb02ff9bc@syzkaller.appspotmail.com
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>

Acked-by: Paolo Abeni <pabeni@redhat.com>