Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp425804pxa; Wed, 5 Aug 2020 04:59:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7GHkSOvmI3SLqZoHnPBSrxKA41ixVVWY4il3Gw/jGjLo5p2Opuj33wV616QNyhZM5U+bJ X-Received: by 2002:a17:906:1453:: with SMTP id q19mr2890011ejc.111.1596628791821; Wed, 05 Aug 2020 04:59:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596628791; cv=none; d=google.com; s=arc-20160816; b=X81R1jikKr+wT0CvK3aNZ30XxwP08NjAfRjyrn8r6N1/v8Rn05DI7m6zDLdMrVIhLh xaFg3kJgGtcrCJOhJ0yr5ERja+DgEQ+179KLidzBTSSeoWwS8HDH0OmQJxOgmcW/kXyY dniY46jo44pUKEX63FB8N8G2efb8bWUWMXJr5DbgJbcZIiOrJgYWYv8m+pNPzDTwM/TO HHCL+U3KBkkLYmGIKE6AQa4f7TpZsaRNi8P6Hv2UYy4E8M9hnIK09+YbfBSAdscY25Kl k1/+AbgcJ3kNIdM38+e5XezQq4QhR9NSGds2JKXjJXTLS9oa1y3DvIse7KMn+ijMbDTN QTrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8RIcTd3ABY0HbBAF2GM18O/8A7XLSuzuqO/LHZrTwtU=; b=M0KU/60QmtPaJGTXMafaVTkyDs/I/HjIa75I+gCA4DLLBdik/XFeJ8oH1/oXZMHhOy QGfZzZi0hNNJLwEJ0yVUxeb5jN/O/xoen+EtzUR1h1/iO5lHU+Q8bMdAodeC0vIS2Wsq umISv7nS0jt+hAjnuaqcnt/3236SEENNZuvK2qBXYPEVjN/mA7XPrEjbtusMjkcCVKJf vu6I4NQDxu16ReXpXGoZlz0O22wKg+OKUXA3q2dYSjGIfJXWMUXcCCzN/f0a/L+6481m 1Al69qXQrBphbDGR4VLNCCrTnSDaSfRN/08dygqWVndpXS4uiT8WrOO2dCEXFuZImOU0 wsNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mznLBtYS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x8si1086211ejs.414.2020.08.05.04.58.15; Wed, 05 Aug 2020 04:59:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mznLBtYS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728357AbgHELLu (ORCPT + 99 others); Wed, 5 Aug 2020 07:11:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:51914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728175AbgHEKt3 (ORCPT ); Wed, 5 Aug 2020 06:49:29 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6197C2173E; Wed, 5 Aug 2020 10:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596624568; bh=TuD7rFAbWeXGXfO48w+uANMpsm8+3sr+qVMoZIj74Wc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mznLBtYSdMwh7Rxb/WqB+6kygGvOEhGgtGchcIiA5nuPKrsZvrCMIk247BwdWV6GP 4gm+EBZY8HCesibxRB/KHu2NGYSyhprYQk17/JkgBIHtxRB4ZzmZAQFrwTD1STA0vj pBJ+ur/kPc/lYpZhzjRvd241Ozw3HBi+xm+v36yE= Date: Wed, 5 Aug 2020 11:49:06 +0100 From: Mark Brown To: Alain Volmat Cc: amelie.delaunay@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabrice.gasnier@st.com Subject: Re: [PATCH 02/18] spi: stm32-spi: defer probe for reset Message-ID: <20200805104906.GB5556@sirena.org.uk> References: <1596610933-32599-1-git-send-email-alain.volmat@st.com> <1596610933-32599-3-git-send-email-alain.volmat@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gj572EiMnwbLXET9" Content-Disposition: inline In-Reply-To: <1596610933-32599-3-git-send-email-alain.volmat@st.com> X-Cookie: Fast, cheap, good: pick two. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gj572EiMnwbLXET9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 05, 2020 at 09:01:57AM +0200, Alain Volmat wrote: > - rst = devm_reset_control_get_exclusive(&pdev->dev, NULL); > - if (!IS_ERR(rst)) { > + rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); > + if (rst) { > + if (IS_ERR(rst)) { > + ret = PTR_ERR(rst); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "reset get failed: %d\n", > + ret); > + goto err_clk_disable; > + } This will not provide any diagnostics when deferring which isn't very helpful if there's issues. --gj572EiMnwbLXET9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8qjqEACgkQJNaLcl1U h9AfFgf+Mr4pGgE8brqH0oVCwN0GR7P/KHKjoEu7C48dCVJ/Lafn8xQ56JOQEt2Y QtnuobjoB+Aki1qqzYB7AdBhSbcGzn7nn11us2yX9l8mfTEEabJzpjGRVvWEazYq pQAm0glN9EyuWJXFu8Fhi/VKCAHVJCuQ3oPovefH1zqgO9iF0nVGmq0BFYUR4aGI tggDXwwrdiEZYcsgvdQjLc3SV+sur+7rgnRyLcZXYyfuWCrQVDbH88TdzpuZAjok TCMjGsG0hg34iAYLI5+5W0TQyFvGyc9IVrLOC680ApM4xsJAJhDeXugzRqKDpYIv zvam9f0cn5IjneizIVbdkkKzvfsz1g== =0sVy -----END PGP SIGNATURE----- --gj572EiMnwbLXET9--