Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200722051851.72662-1-hexin.op@bytedance.com>
In-Reply-To: <20200722051851.72662-1-hexin.op@bytedance.com>
From:   =?UTF-8?B?5L2V6ZGr?= <hexin.op@bytedance.com>
Date:   Wed, 5 Aug 2020 20:29:29 +0800
Message-ID: <CACKzwjntROYA0WjdVewmozrXnzb=YX2dvqHgEpj4POOy0-QXOw@mail.gmail.com>
Subject: Re: [PATCH] drm/virtio: fix memory leak in virtio_gpu_cleanup_object()
To:     airlied@linux.ie, kraxel@redhat.com,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     dri-devel@lists.freedesktop.org,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, Qi Liu <liuqi.16@bytedance.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Xin He <hexin.op@bytedance.com> =E4=BA=8E2020=E5=B9=B47=E6=9C=8822=E6=97=A5=
=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=881:19=E5=86=99=E9=81=93=EF=BC=9A
>
> Before setting shmem->pages to NULL, kfree() should
> be called.
>
> Signed-off-by: Xin He <hexin.op@bytedance.com>
> Reviewed-by: Qi Liu <liuqi.16@bytedance.com>
> ---
>  drivers/gpu/drm/virtio/virtgpu_object.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/vi=
rtio/virtgpu_object.c
> index 6ccbd01cd888..703b5cd51751 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_object.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_object.c
> @@ -79,6 +79,7 @@ void virtio_gpu_cleanup_object(struct virtio_gpu_object=
 *bo)
>                         }
>
>                         sg_free_table(shmem->pages);
> +                       kfree(shmem->pages);
>                         shmem->pages =3D NULL;
>                         drm_gem_shmem_unpin(&bo->base.base);
>                 }
> --
> 2.21.1 (Apple Git-122.3)
>

Ping guys. Any comments or suggestions=EF=BC=9F

--
Xin He