Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp653873pxa; Wed, 5 Aug 2020 09:38:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMbuZbhkvbnl5tmR8zqMPEQbwJL8Yiz380RV+E72z+3z45cQ+6BNQzWJn+kiKuQqCCrfRz X-Received: by 2002:a05:6402:297:: with SMTP id l23mr91817edv.145.1596645523691; Wed, 05 Aug 2020 09:38:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596645523; cv=none; d=google.com; s=arc-20160816; b=WnFqm7WViUjN30TBmGu6hiU6AcHSE9MMmp7vKsznLWuCt6bnJHJtJGGxkgg9pXByNO 0FnaLhnLQ5/0nNfxWMFDB+uP/KqJJtLGv1y6l7+lqKOru32LGoc5ZTLRlKcI2QFGzTMS NlO0mUHSueVk6VuntmDPSQzelW9/tX4bKWa5qyg29BuZe/icALipROAgTsai0FnXYszR 5Q0jeZBuOnK3rbizmKabGnjW0+Z+9uk07LEo966h6mSvQ7k7dSAQfCWYgbKF+IYs3hmu Fe4E/qpCUgb6tRQCstGW+Lb8SNyMURGMJhWIBmtnGZf79xYBKA4KK6E/26E+HxKyv5Fc pYWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=djBCWmx0W0tmhBbcT+0QJ8hwEZIOWZB8n+AEEtVSw7o=; b=NLdhF3SLVA7gGUHw6nJnCKs2fsTTPt607NQIL1fvlvIU/k5zENdcHK+BBjBak0q1Tb XTeSx1j7eUnO+rkZJxvXDEO1+NEiLsZ5cn7fedyJNEXbZbjnD3IyYpDzpmJVzaJyNvJn nMNpD2WAbExqhl8SvCToBJRh7ZftikpHs8aU5lbA/cMRI1vOxqF01NMJzNt0Nj61ZTdG 4pYzW8KbPQLF+WzKF+s0sPpAXMGIEQlJjCIMZWW1qJ/A0s3cZdhMSNKpF+Ylg4pvVJef k+9zeg34gGblNDFGtK5Jfn1FUMsi51d34oRhBoxcl5XlXwpr7xskjKa9qSYVxblUpAyi wHhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b21si1469902eja.19.2020.08.05.09.37.52; Wed, 05 Aug 2020 09:38:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727861AbgHEQhm (ORCPT + 99 others); Wed, 5 Aug 2020 12:37:42 -0400 Received: from mail.ispras.ru ([83.149.199.84]:43470 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727066AbgHEQe6 (ORCPT ); Wed, 5 Aug 2020 12:34:58 -0400 Received: from hellwig.intra.ispras.ru (unknown [10.10.2.182]) by mail.ispras.ru (Postfix) with ESMTPS id 11CDD40A204E; Wed, 5 Aug 2020 12:48:41 +0000 (UTC) From: Evgeny Novikov To: Jiri Kosina Cc: Evgeny Novikov , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] HID: u2fzero: handle errors of u2fzero_fill_in_urb() in probe Date: Wed, 5 Aug 2020 15:48:40 +0300 Message-Id: <20200805124840.6893-1-novikov@ispras.ru> X-Mailer: git-send-email 2.16.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org u2fzero_probe() does not handle errors of u2fzero_fill_in_urb(). The patch fixes that. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov --- drivers/hid/hid-u2fzero.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-u2fzero.c b/drivers/hid/hid-u2fzero.c index 95e0807878c7..0632f6c3aa66 100644 --- a/drivers/hid/hid-u2fzero.c +++ b/drivers/hid/hid-u2fzero.c @@ -315,7 +315,11 @@ static int u2fzero_probe(struct hid_device *hdev, if (ret) return ret; - u2fzero_fill_in_urb(dev); + ret = u2fzero_fill_in_urb(dev); + if (ret) { + hid_hw_stop(hdev); + return ret; + } dev->present = true; -- 2.26.2