Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp658780pxa; Wed, 5 Aug 2020 09:45:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzukX8l7WptREmemUaOsWtGNoJLXfWKHpGoamT6rjzwR4HN/3bOXjWrwEiPQhUXHUWZ2Qe X-Received: by 2002:a17:906:9984:: with SMTP id af4mr190586ejc.90.1596645900839; Wed, 05 Aug 2020 09:45:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596645900; cv=none; d=google.com; s=arc-20160816; b=DL8g8th8Nrym/kyBWGCg/n46p6J/ACvAQpOHVuAgt1pLFRfHYTgdA7SUnCO35HfLas 41Tulfa8S8iKq+Zzr+hDWr0orkg8Aio4Xnu18huT1cgz8jRL9pkD3EsNvPWAJJrK6JDe ILEy+8vK1UJ2D8WMHc88pJCzWZqd+8Lltw0JrOglquys+HZcgkHBFN1n7SnbyQ3FAKGx ROrxN9eD1GwaBs4GAZKS7Rie6s3r1gfGrlcpCqHLZG48fYjvv5vBxWAIh4W5Nmrft5xz 1gbPoHn9UISJPqwmwjzTBHK+3lc08f7goBaBkFBfjzW4gqruZAUYO2Ye4js33bbhfcOX ncKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7pIsLGqMjIgL87suiIaeNB75q2taIqw/jMzR5b9gh7E=; b=aj1MRIVrphoAKy9ayvSLfAbOHqHND04nT5gk+0+0tOlPCBQqXtsX5Lo09YvZdxKH88 uRQzJX2ihhUE5r5svWKbQm/mLXGd5ButemkTs1ewOVun9vS8Uw41o6zIatGXgb7/qXw+ so43tVxDGhlEdgzvM1e+2E3BdgdTDHRA2dVQdZNHFrj5mCqUuY8JgBRDD09Wt9DHK1Wj IsAAFqipC44rjwsShv/qXXu6ISq2CnhmonRqI4XdUH6jpu2Y6umpkg8MnUpRqp9c/+1Q wdsUC6kMaUpJEFjVDTXkGJ9r9yIE3VSQOjFt4P47vX9LnvuIeim6CuMo9yRhIJXWC231 H21w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=gVqWoW0G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n22si1565956eds.472.2020.08.05.09.44.10; Wed, 05 Aug 2020 09:45:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=gVqWoW0G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727066AbgHEQlQ (ORCPT + 99 others); Wed, 5 Aug 2020 12:41:16 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:52080 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727115AbgHEQii (ORCPT ); Wed, 5 Aug 2020 12:38:38 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 075BS1Fh028001; Wed, 5 Aug 2020 11:34:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=7pIsLGqMjIgL87suiIaeNB75q2taIqw/jMzR5b9gh7E=; b=gVqWoW0GUND4SXsTdTj42hKtT0Igc/eqPZHKXy9+Scve/pr7PhCMgzFgeQI5cpBodBpv 9kDGVgtNjb5MQCGBVcPm1yOR16evziikZafORHUebh4NXuNDy/zcWyx45GA72fWeMtkP 80mlyaQRUR+Bvz1kVB6AB7NI+8F/1o5vrLQl5IkMQkb9SPt4pnU3s4irs7nb2eP7jjw4 SDHe2I5M0ATO2MW3KMNrJqQg/Jyjc8FFepZotFa3aK5K/TGExTwZ0ThJ2W2Iw1aG3hTg NTgV/wRElZ0Ils+pFAPXe0vnrNxKtp43x+54g8EJWhWxn/otPhiQDpQYgfKEvJvvKsad Ow== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 32qnd41rw0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 05 Aug 2020 11:34:08 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 075BSswc034976; Wed, 5 Aug 2020 11:34:08 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 32pdnt2jk4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Aug 2020 11:34:07 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 075BY3U2012723; Wed, 5 Aug 2020 11:34:03 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 05 Aug 2020 04:34:02 -0700 Date: Wed, 5 Aug 2020 14:33:51 +0300 From: Dan Carpenter To: Viresh Kumar Cc: Dongdong Yang , juri.lelli@redhat.com, peterz@infradead.org, bsegall@google.com, gulinghua@xiaomi.com, duhui@xiaomi.com, rocking@linux.alibaba.com, devel@driverdev.osuosl.org, vincent.guittot@linaro.org, tanggeliang@xiaomi.com, mingo@redhat.com, yangdongdong@xiaomi.com, mgorman@suse.de, linux-pm@vger.kernel.org, rostedt@goodmis.org, fengwei@xiaomi.com, taojun@xiaomi.com, dietmar.eggemann@arm.com, huangqiwu@xiaomi.com, gregkh@linuxfoundation.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, zhangguoquan@xiaomi.com Subject: Re: [PATCH v3] Provide USF for the portable equipment. Message-ID: <20200805113351.GE1793@kadam> References: <20200804054728.ojudxu5fmd54lar5@vireshk-mac-ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200804054728.ojudxu5fmd54lar5@vireshk-mac-ubuntu> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9703 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 mlxlogscore=987 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008050096 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9703 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 clxscore=1015 mlxscore=0 priorityscore=1501 mlxlogscore=999 malwarescore=0 adultscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008050096 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 04, 2020 at 11:17:28AM +0530, Viresh Kumar wrote: > Sending updated patchset for this isn't going to help you my friend. You need > people (maintainers) to agree on the idea here first. It doesn't take much work to make the code look nice. Writing pretty code is always a good idea because then people assume you know what you're doing. regards, dan carpenter