Date: Mon, 15 May 2006 19:53:06 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org,
       Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] x86 NUMA panic compile error
Message-ID: <20060515175306.GA18185@elte.hu>
References: <20060515005637.00b54560.akpm@osdl.org> <20060515140811.GA23750@shadowen.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060515140811.GA23750@shadowen.org>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1068
Lines: 27


* Andy Whitcroft <apw@shadowen.org> wrote:

>  	if (use_cyclone == 0) {
>  		/* Make sure user sees something */
> -		static const char s[] __initdata = "Not an IBM x440/NUMAQ. Don't use i386 CONFIG_NUMA anywhere else."
> +		static const char s[] __initdata = "Not an IBM x440/NUMAQ. Don't use i386 CONFIG_NUMA anywhere else.";
>  		early_printk(s);
>  		panic(s);
>  	}

i still strongly oppose the original Andi hack... numerous reasons were 
given not to apply it (it's nice to simulate/trigger rarer features on 
mainstream hardware too, and this ability to boot NUMA on my flat x86 
testbox found at least one other NUMA bug already). Furthermore, the 
crash i reported was fixed by the NUMA patchset. Andrew, please drop:

  x86_64-mm-i386-numa-summit-check.patch

(which has nothing to do with x86_64 anyway)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/