Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp770883pxa; Wed, 5 Aug 2020 12:20:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYffVO/EHcVx6lVN8YeuPpEE3iprV2gGJyB8y110p1eoK0Sx7nhb2t1rRObvYZmMAF3IH2 X-Received: by 2002:a17:906:c002:: with SMTP id e2mr842418ejz.244.1596655233043; Wed, 05 Aug 2020 12:20:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596655233; cv=none; d=google.com; s=arc-20160816; b=pyDtydi72WYypBYcl68ZGp8XPQO5Yq1W4Ywl6VVofXwHy+Co2u02nYMdopkeF8pXRa FKueglqrk8EeXBJ0mXP9eXADs0g9CGoUqCb+p9hjO5u2yYVEZX7cUnGiT1at+rCsvEcM sgtI4D9Sy67nOTH1MipINjhUkhWpqP2g+aW5yMNVTmluCw6ki5udm0C1ujwib0yfdMV0 UN7zOy6nEnODq2TyLFDjHlH5CHKbCR09e3cf5RejGGSGH9Xfwwf5VSIgdZbpZwRaVzWV 5mhROOEdfgUvW0+TYmMpaRT9SujZPqy8x3C+dWjN5k9kDRlFYBrXr3Ez4qkZjq8yfqNi vZ0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=4bk8QTTSWRZDDEZz6dJSVccqHKuEZFATPzYwemOEjog=; b=lG/gAvhYVmwnVdvhgp+VtdbOXwvyLa1QM78YYGSw/uw0KhmKEusYoQOzupusAr26eu RBl+ESxb/OtT6pZ3ygjaM9E/xlbpQMtceBXB0XcBBHu4soT3rNdGzSVE4UP6Hbp0u+51 plPMjZVSR5i6wMNy0Bw9pd7xMkFmIv1VgjmedFZTwM7YnHc4EdJ1nSrDCbGC7EtAy/XS lSwCFAiBm8UJSwLh5tGqW3cWjk6h00iISRtUFP2ZHgKanHqKd36+BkwT1KdUpV0FrbUM 7WXBsP8tYk0xoBL26dmV1FmJzYzItJKq9Lo+kGhGCKgILWnn6tYtptwzlrbxTbGesK7B E8Tg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ov12si1800036ejb.671.2020.08.05.12.20.08; Wed, 05 Aug 2020 12:20:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728795AbgHETRt (ORCPT + 99 others); Wed, 5 Aug 2020 15:17:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbgHETPo (ORCPT ); Wed, 5 Aug 2020 15:15:44 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B922C061A29; Wed, 5 Aug 2020 12:13:22 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 57300152E87E4; Wed, 5 Aug 2020 11:56:35 -0700 (PDT) Date: Wed, 05 Aug 2020 12:13:20 -0700 (PDT) Message-Id: <20200805.121320.990654813010240919.davem@davemloft.net> To: xiangxia.m.yue@gmail.com Cc: echaudro@redhat.com, kuba@kernel.org, pabeni@redhat.com, pshelar@ovn.org, syzkaller-bugs@googlegroups.com, dev@openvswitch.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: openvswitch: silence suspicious RCU usage warning From: David Miller In-Reply-To: <20200805071911.64101-1-xiangxia.m.yue@gmail.com> References: <20200805071911.64101-1-xiangxia.m.yue@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 05 Aug 2020 11:56:35 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: xiangxia.m.yue@gmail.com Date: Wed, 5 Aug 2020 15:19:11 +0800 > From: Tonghao Zhang > > ovs_flow_tbl_destroy always is called from RCU callback > or error path. It is no need to check if rcu_read_lock > or lockdep_ovsl_is_held was held. > > ovs_dp_cmd_fill_info always is called with ovs_mutex, > So use the rcu_dereference_ovsl instead of rcu_dereference > in ovs_flow_tbl_masks_cache_size. > > Fixes: 9bf24f594c6a ("net: openvswitch: make masks cache size configurable") > Cc: Eelco Chaudron > Reported-by: syzbot+c0eb9e7cdde04e4eb4be@syzkaller.appspotmail.com > Reported-by: syzbot+f612c02823acb02ff9bc@syzkaller.appspotmail.com > Signed-off-by: Tonghao Zhang Applied, thank you.