Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp772537pxa; Wed, 5 Aug 2020 12:22:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+WfVc+/K1px3fvMxCEcBGOym2WRsbQd4RgZIc/ECPMTr6KnuXJ5+tLtGyB93cqcqvPazE X-Received: by 2002:a50:a125:: with SMTP id 34mr779295edj.306.1596655377059; Wed, 05 Aug 2020 12:22:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596655377; cv=none; d=google.com; s=arc-20160816; b=hwNB8U3dX9UP3tNBLC71LBfsK8nlwT8/r0aUVBTdsAQYDyiYEvxfPz9BL+v2llYMLG Q44Jp07a2iCeMWCfXNbChb5okB4AtDxWoxS/kr1AIIRs7oGo4niHYaC1h5ZXsVB8LFVK vRZgIU/0H19fDWYY+jUPBdEuAv+P7emJMVacDXNHY+E9V6ynPmRo/I3PCxZ/LZ6cvKwf s2k0+o7p0C+Om7AAxyixuDpNu1sDqkAo1SQjhh46hZU/VML2pANizk8RNVMDsXaCD4eO z/JboGvm1i3o/TF1mMLvUSkIs/E2zls1TbGVUXbZ8HlSHP+S7qQEiC3qYwjjzMWDF1pR pmSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=cmz98b4aN6klrGIsOTUwn9K0/pumDsFYeqieDUYCi30=; b=tjrwj6bSiDuQO/KTLoPpWt8T1onv/ldK4CNaLoOfjlXGtJ7wvoC1rqcKrHQoZGrd0b EsgBI8qJ6Z94mczKYIErYJGlRnPBJT5OMF9YOE4mPedcxVuDCMwpfR6vfw6zwPRL7w+p F13MlQhI+m8owFN21/Zrxj3xtY7RDB8ZXoYkN7yQGmIXm5T9Dzm14g4x42Oi+kvf5GkQ D0PkXaYLnN38mCI4Uud/BjA3DX4MC5qpjyamTfC4TYl6AQncvdfislh1zcs3OwTuES7f pRVJtcFZLqafVOYMK747XEOKV1l9l0xzxGv4FtXSScIBS5ZaUTrswLgSDOP0DUzoyVun 1QUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SVIFO7jx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f10si1791015edx.485.2020.08.05.12.22.33; Wed, 05 Aug 2020 12:22:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SVIFO7jx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728451AbgHETWV (ORCPT + 99 others); Wed, 5 Aug 2020 15:22:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:43120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728972AbgHERl4 (ORCPT ); Wed, 5 Aug 2020 13:41:56 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C4DF22CAD; Wed, 5 Aug 2020 11:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596625347; bh=cmz98b4aN6klrGIsOTUwn9K0/pumDsFYeqieDUYCi30=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SVIFO7jxtvIz8aTDGf7shxm4OV5InZb/7jnDWISeCyJFZ4UJQtRfFtLzIm4cnB7bc 04VZ9RTFmwFOce4ZsAgN2Sg5khJDyARPhguXwycRZ6mCSA8bnLG95y5recuPWh8wh+ fwpV+5nUZvh2jhG5qgSWRza5gtkWletx20dKAVGE= Date: Wed, 5 Aug 2020 12:02:05 +0100 From: Mark Brown To: Alain Volmat Cc: amelie.delaunay@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabrice.gasnier@st.com Subject: Re: [PATCH 13/18] spi: stm32h7: fix handling of dma transfer completed Message-ID: <20200805110205.GH5556@sirena.org.uk> References: <1596610933-32599-1-git-send-email-alain.volmat@st.com> <1596610933-32599-14-git-send-email-alain.volmat@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="svZFHVx8/dhPCe52" Content-Disposition: inline In-Reply-To: <1596610933-32599-14-git-send-email-alain.volmat@st.com> X-Cookie: Fast, cheap, good: pick two. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --svZFHVx8/dhPCe52 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 05, 2020 at 09:02:08AM +0200, Alain Volmat wrote: > From: Amelie Delaunay >=20 > The rx dma is completed "after" the last data is received > from spi. Thus, to avoid loss of rx data, it's mandatory to > wait for the dma callback before tearing down the rx dma in > stm32_spi_disable(). Again, please put fixes at the start of the series before new development. --svZFHVx8/dhPCe52 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8qkawACgkQJNaLcl1U h9AC7wf/Tc9hKs/yIxoXXdFXrgFaODwz5noiIf85U1PqJmzIfy4Q0csYUwSL+p03 vZmqEmP1gK3M+JsByWO+nU3KBW40ZbfLzoEuYTjfCyg3fqlR83UW+fI2s8H9ddcc IKjdXeSDZJzL/c+SOzHq6eMcRN/UT1K19TibNV4kuTbfOU29/uMnF87jyk7k8mzy RPq0QgjVFnU5EL4lUXha1Vq1p7jGVhKA1iR8yqBwP+aHbgfC6M8tueHPjztMbVX3 fWF+54fHl9URy1O3f5ymycoNqXfHiKrjsIbCzpA9rcWILZNht5qf+YOasDNUJ0Ai VYjSU+o3H9L1uJKSd2QoZlsnRNUswA== =ARDB -----END PGP SIGNATURE----- --svZFHVx8/dhPCe52--