Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp773443pxa; Wed, 5 Aug 2020 12:24:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqwmxR0FGtUzl36DcT7S+NAoUvNZoOghhpaxe3n+fFpJ1rjZ/WxZZCl/AXAbW4JAIkr09j X-Received: by 2002:a17:906:fcdb:: with SMTP id qx27mr753446ejb.421.1596655451626; Wed, 05 Aug 2020 12:24:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596655451; cv=none; d=google.com; s=arc-20160816; b=r0cf8DLmpJRtNLxZM4DsjjGUeXQzwWbjOvcHELkb9XwHvC2UMaqsIbbkT5F+PgaErI mpfic8fRTpU2JKViqz+7ZWG8qv0hDr8a8O4UCnWrQdmX24h1ofIRZHRsVtzCcKXd3TWH DnZdBxDVxkK1EZO4NwGXi7+rvMYiQLtvcXBrsUXM1/Ur14VCotjm/uyBFMHqOKZVus49 23zVAJKgFNa1iajMIX9sw9suKpWn4Y/BS4FTHMNop0ToCHDXfNuorUTjP+4ciQMVcri3 koicLo6LmCo1yF3+X5eIstOjoZ5f+PhdPArMyCxbjyDExw64wM5ir9FJMCu8JEzDoWSs WICg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=itzMvNq8nfgP8VKXOJXPOoZfq8+Pd5YP4oo6JUWZy/Q=; b=eNWki7yGvXhsojAVvq5b+FrIjB5R5gG6kISY1GfhsJK9ZmA3G5bA0ZH2r1Ct1maWFr TuMFyZ2zmq9b2dm+Y+YjTUIwA4oAVxxHMlF8wgWLPDy/UIzEERYnIauEEpKhs8bfUfOD goY/QI7B5HeNvlQcsRdmmZzLhd+Ai6Hi1P4pUKL8VYNEr6gNJhaLOZwM/yMI1uTQcfUl G2kS2hhVQ/vXujrUbBUAWIt+TRAxn+dFIapF2fOjiVC1qeO0/s4ueOgnqF0hUWsr8We0 n3VLLD57CyH+jU0C6+1u7wRiBfLCYRBX1N4BEssY4pRs+U/6b8xNJp4mADkWgdTltP6E Ir4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=daILxyCw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p7si1743760ejo.392.2020.08.05.12.23.46; Wed, 05 Aug 2020 12:24:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=daILxyCw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728990AbgHETV1 (ORCPT + 99 others); Wed, 5 Aug 2020 15:21:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:43132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728977AbgHERl7 (ORCPT ); Wed, 5 Aug 2020 13:41:59 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E99452173E; Wed, 5 Aug 2020 10:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596624860; bh=itzMvNq8nfgP8VKXOJXPOoZfq8+Pd5YP4oo6JUWZy/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=daILxyCwv0M7mQeyhNXxvi03DAUtga5jJtqn9dQXwRgrXBcNva8DPZDusD/aFamB8 Au9mHe9ABAS9MqqceMBsO7YPBu1LumIOWL9uh+TWE/OO/RKyxryVA4IqaKwGaUH9uK 2Cbco3etFIjw9O/v4cujAsyuMP3cTEND8YVamfgM= Date: Wed, 5 Aug 2020 11:53:57 +0100 From: Mark Brown To: Alain Volmat Cc: amelie.delaunay@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabrice.gasnier@st.com Subject: Re: [PATCH 09/18] spi: stm32h7: fix race condition at end of transfer Message-ID: <20200805105357.GD5556@sirena.org.uk> References: <1596610933-32599-1-git-send-email-alain.volmat@st.com> <1596610933-32599-10-git-send-email-alain.volmat@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3Gf/FFewwPeBMqCJ" Content-Disposition: inline In-Reply-To: <1596610933-32599-10-git-send-email-alain.volmat@st.com> X-Cookie: Fast, cheap, good: pick two. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3Gf/FFewwPeBMqCJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 05, 2020 at 09:02:04AM +0200, Alain Volmat wrote: > From: Antonio Borneo >=20 > The caller of stm32_spi_transfer_one(), spi_transfer_one_message(), > is waiting for us to call spi_finalize_current_transfer() and will > eventually schedule a new transfer, if available. > We should guarantee that the spi controller is really available > before calling spi_finalize_current_transfer(). >=20 > Move the call to spi_finalize_current_transfer() _after_ the call > to stm32_spi_disable(). This seems like a bug fix and should therefore be at the start of the series so it can be sent to mainline without the new development work. --3Gf/FFewwPeBMqCJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8qj8UACgkQJNaLcl1U h9BPMwf/SVAa/tykTrFSDmtKpWBCSoTEQyhwBfjKuq+rQf3+01Akz63PIPooThf4 4hcsMCzyVNfFiNhOCvCyeK5ccZ3iJ6ZX+CBzIp82qadb35VN1MNxMVwHPy2kshTW 8S+oKpDXRIFEiuKmDTBW22swtHCy8m01Ng4gQXvQPBhdjIpff4sl/kAMBxPRUFBS TjkRi39WPFNwmRWRBrAxa99mmyOt0+83zOs0jjLRRJADsfoIaDdkISbFGJ517Wh1 10XUqNK0kNJC8hqj6rK7jgkgQeMW3vAQaimhlJzFbnjVOgtiW74zF03RPmxM1w6V R+0IRfA+AzMkXP1gTek7e+vjuBraaQ== =4szv -----END PGP SIGNATURE----- --3Gf/FFewwPeBMqCJ--