Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp776065pxa; Wed, 5 Aug 2020 12:27:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfbSCKML/yOTrQHe01aY74Fl0DjBxdqdI8MK+XD2wk2AV4phY+Y2IF2oggLTVcEYU5MwwX X-Received: by 2002:aa7:d948:: with SMTP id l8mr760518eds.371.1596655674170; Wed, 05 Aug 2020 12:27:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596655674; cv=none; d=google.com; s=arc-20160816; b=U8fduLASKxDVUykxyJHnSxeumwtV2n+wA9T/9cAmNgKdKCXI9Be0lrzSNHEnRk3UYW ysvH7UebRlXQpmaiU9IBXWVTrkfcvuw61O023FVJcjccA5F+VZ+IBeiulnMZj/jycYKU VN7tSBx4m9K/204drvc2ytcGPbgTkFgg5eDK5NKDHs02eDw4pGJhjQC+zf5LUdQqFyuB 3a9O1GQAQG8NDreybI9bzHseLtl87aAW5QWwWXi2W0D66Ba4DodmnCAB0AfVnDPPGPDC E8QB57uRmcin2sye8OptU8Uv9vU9JpSQr7B7BozHyrLCEhom7L9E2IoEu2CgzCyTM3C5 2c2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=f1A99Kan+ToYvUmOMuODkd0BFkRSjBNq3WkT2nA5570=; b=iCvliA0vVJhoW6V70nCNVE5l6SdlAtxdnoVCkKGa3ywwGmCPYHaQVLj4f34yKGajKp IPeH7GJSvCpI8SaP0Tv/mlzj6o1wT8gM0ZlTAD6pv5DFqKAOy75LVwQ+HqbqMsPoVfkh 5aW2HcINkprqye90s9K7BPJqTTYLALkch6FQz4hR3e90H95oaU286nVBz4r3l6BmvdBO fPsjAGvj+zSl4M18t0I5KuQNO2JJaEmsJbliDCa03PKEuIQT6O9IZdhIhqMwDNeeIGTK RA8nkeJ29N41wWDx78hKq9pq8Qvo4jSJKRmATG2LQiBkhhUkVyJ3pbIo2VxvDYew6De9 4r+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dR3nXJcO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dc15si1871086ejb.374.2020.08.05.12.27.30; Wed, 05 Aug 2020 12:27:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dR3nXJcO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728474AbgHET1O (ORCPT + 99 others); Wed, 5 Aug 2020 15:27:14 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53682 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728645AbgHERNE (ORCPT ); Wed, 5 Aug 2020 13:13:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596647582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f1A99Kan+ToYvUmOMuODkd0BFkRSjBNq3WkT2nA5570=; b=dR3nXJcOxXQhXr4gn6VmnbjOJP1FxOpoj2yjDm2sGOB2XQpNQ99v7U/3kvvgfu2ewkayRf Mn68IMjrF78i0E6dWUf6UonGQbjnuSf6zeMNP4h7bmrKiCr5kRQkOMBWv3GbNGUE/rYh6a XuR6rfx7M4qLvf6K9kuF8xUCy8KVRQA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-YGQs7NjpOLOPTbjI2RF8dw-1; Wed, 05 Aug 2020 09:44:15 -0400 X-MC-Unique: YGQs7NjpOLOPTbjI2RF8dw-1 Received: by mail-wm1-f70.google.com with SMTP id v8so2472111wma.6 for ; Wed, 05 Aug 2020 06:44:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f1A99Kan+ToYvUmOMuODkd0BFkRSjBNq3WkT2nA5570=; b=RmQjnOjh0hU13RKHQJropXLjhmfjSglH0WbBkyo/rEZJJ/yPBRrGOX+eU5vCwIa6sA A9hRyDt+i9QdMUtRKgkqpzXDQARRHA5KDE0FeuEHtrB3nsi5c2CLle5z4x93UnG2JTZ5 pcSZZp3WGNCergW0SiXllQqIBLFHFaiLsvWeN6Z/vKSp7djIxlMZ/jwhVQPFVHuABpmI vyo4kBJrvVKzPQ4/5fRt5YCy9zGVytWEAkbYSB6xWs/HogFgXYi1JSpvYbEz6/GQXKgR 0w82e+SI+hOSS0dZc+Bc/Gok3NVA74eOP0shV8U/3pj46pJNgEKFQyyCMD8eu/u+Ns/T k4oA== X-Gm-Message-State: AOAM530nS37PNfNZ19yGdeOv/sU8/dWSA84L4ob5nNxjHloIUebpKMGP pQnWD9dO872K1A1O5MHafan3CAjixkHkLBySWPYg3USeIDlaP9hknCaojq/7IxS+jXVsXIvn0I1 6u6hWOFdjrG29Yo4QzF8QTAW7 X-Received: by 2002:a5d:56c9:: with SMTP id m9mr2815443wrw.311.1596635052938; Wed, 05 Aug 2020 06:44:12 -0700 (PDT) X-Received: by 2002:a5d:56c9:: with SMTP id m9mr2815427wrw.311.1596635052770; Wed, 05 Aug 2020 06:44:12 -0700 (PDT) Received: from redhat.com (bzq-79-180-0-181.red.bezeqint.net. [79.180.0.181]) by smtp.gmail.com with ESMTPSA id o30sm2873971wra.67.2020.08.05.06.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2020 06:44:12 -0700 (PDT) Date: Wed, 5 Aug 2020 09:44:10 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Jason Wang , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: [PATCH v3 20/38] vhost/vdpa: switch to new helpers Message-ID: <20200805134226.1106164-21-mst@redhat.com> References: <20200805134226.1106164-1-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200805134226.1106164-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For new helpers handling legacy features to be effective, vhost needs to invoke them. Tie them in. Signed-off-by: Michael S. Tsirkin --- drivers/vhost/vdpa.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 18869a35d408..3674404688f5 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -118,9 +118,8 @@ static irqreturn_t vhost_vdpa_config_cb(void *private) static void vhost_vdpa_reset(struct vhost_vdpa *v) { struct vdpa_device *vdpa = v->vdpa; - const struct vdpa_config_ops *ops = vdpa->config; - ops->set_status(vdpa, 0); + vdpa_reset(vdpa); } static long vhost_vdpa_get_device_id(struct vhost_vdpa *v, u8 __user *argp) @@ -196,7 +195,6 @@ static long vhost_vdpa_get_config(struct vhost_vdpa *v, struct vhost_vdpa_config __user *c) { struct vdpa_device *vdpa = v->vdpa; - const struct vdpa_config_ops *ops = vdpa->config; struct vhost_vdpa_config config; unsigned long size = offsetof(struct vhost_vdpa_config, buf); u8 *buf; @@ -209,7 +207,7 @@ static long vhost_vdpa_get_config(struct vhost_vdpa *v, if (!buf) return -ENOMEM; - ops->get_config(vdpa, config.off, buf, config.len); + vdpa_get_config(vdpa, config.off, buf, config.len); if (copy_to_user(c->buf, buf, config.len)) { kvfree(buf); @@ -282,7 +280,7 @@ static long vhost_vdpa_set_features(struct vhost_vdpa *v, u64 __user *featurep) if (features & ~vhost_vdpa_features[v->virtio_id]) return -EINVAL; - if (ops->set_features(vdpa, features)) + if (vdpa_set_features(vdpa, features)) return -EINVAL; return 0; -- MST