Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp793796pxa; Wed, 5 Aug 2020 12:56:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3mCrdOK3NMLLsQF6w3kFnOv8eEra+UfklLD31eAB9xHAjjfx40v+PP2oMJqb9K/T8nN9Z X-Received: by 2002:aa7:d304:: with SMTP id p4mr844112edq.267.1596657405778; Wed, 05 Aug 2020 12:56:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596657405; cv=none; d=google.com; s=arc-20160816; b=YJ0sZsfPnQ3zltoMK11oLOk56tuGWXrk8nbLdNQpA/70ntYwZFTb3TQe6cYacYD2MN IkFhOxvi/GcnMW8GQ10q3av8m9pJFQzMIq0xfNOervNHFY5PagJHj08RTv4Nc0VshAau 3YAtGKozpDI5+n0E6t8f6KEqD0EbtP/t5gnVMZdlDk0g7POAVmrNP/kj6Q4R9rESLt1D WcrzqTK4QS3aC0EQw2OGxUx9oc7vHj2zw0o+J8QPvYEXSxmgAW65s1o3dpCCt5+OnxgF lfvCBruAl0dhKLcOkv7ZAfsYtx8wj64LlOXBfDnY3II7vc7HcfrM7MeVtmxYOUSJCGdS b0UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=4O8NzmpI48gB34jbxeGTk9sMJ+aJbV2Wl8WhAwCHFEs=; b=HIGLBtVNHoqjY9bt/yfgw9eK3tWMImHd/vx/vTpOQIcOu0woJlIcDzB9hhqSj8bX1E KodFyv1MMWECm8vrU1au8351RpHoBgI+1QIrNmtEnPIW/whwtZZf2DCFSRn1zbNBdfQt Nl5z7LN3B76ut+3aez7Zi2HYRdnPMuGL6Oza/fxdccFvdP6a3KNZxFIfoRFeMlEcxc1R kDWdasOG0m0GB0AOOhsv+td0H5kvwCpvCNb0O5P29l3UTyEYeD/xGakaVo3Xp9geBII2 kC2GVy+sbRhc8O/4s9BGmXa7a0SoQ2fu5DKI0Rhk89maLEDgZexp9L2KNiaryZKQ+I+f vyQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=mOeLMqPj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j6si1975138edn.543.2020.08.05.12.56.23; Wed, 05 Aug 2020 12:56:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=mOeLMqPj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728371AbgHETxD (ORCPT + 99 others); Wed, 5 Aug 2020 15:53:03 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:3561 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727928AbgHEQui (ORCPT ); Wed, 5 Aug 2020 12:50:38 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 05 Aug 2020 09:48:58 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Wed, 05 Aug 2020 09:50:37 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Wed, 05 Aug 2020 09:50:37 -0700 Received: from [10.2.172.190] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 5 Aug 2020 16:50:36 +0000 Subject: Re: [PATCH v8 08/10] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done To: Dmitry Osipenko , Thierry Reding CC: , , , , , , , , , , References: <1596469346-937-1-git-send-email-skomatineni@nvidia.com> <1596469346-937-9-git-send-email-skomatineni@nvidia.com> <20200805134600.GA3351349@ulmo> <103efe31-1abc-54f2-6004-490d7bb1b61a@gmail.com>

From: Sowjanya Komatineni Message-ID: <6eede805-80fd-016f-22f8-b6d25f6587af@nvidia.com> Date: Wed, 5 Aug 2020 09:50:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1596646138; bh=4O8NzmpI48gB34jbxeGTk9sMJ+aJbV2Wl8WhAwCHFEs=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=mOeLMqPjDvuvccBzxqxLUuaWmqaolyNmwGtjbFI//CaS63LSk7TnL9piUBpDdzl/x rWY14JW5sC565vIoU7fdDVzr7nK8spgJUzoOOEgBLNj8RRgV52h6zUHb4Oq+2MlfUf kS7a5uMnc5gMII/O8cg+FmwD7CccTwpZTvAANFysHrQWyUvH5ovVasynWM77M64mPG W2vQm2OKEQK5zm/G3kE6xsbXuUOhIjO81vLsNKch1+QsmiIQWyEAaD2aeBFp4p8aIJ Kkf5/4lojEPV4SgAk+aNkV46Mj6rurEr0/hjXyRxUtbKmTE0YarZEQDv1E625JlH37 slgcAvUN039Cw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/5/20 9:47 AM, Dmitry Osipenko wrote: > 05.08.2020 19:33, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On 8/5/20 7:19 AM, Dmitry Osipenko wrote: >>> 05.08.2020 17:05, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> 05.08.2020 16:46, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>> On Mon, Aug 03, 2020 at 08:42:24AM -0700, Sowjanya Komatineni wrote: >>>>>> With the split of MIPI calibration into tegra_mipi_calibrate() and >>>>>> tegra_mipi_wait(), MIPI clock is not kept enabled till the calibrati= on >>>>>> is done. >>>>>> >>>>>> So, this patch skips disabling MIPI clock after triggering start of >>>>>> calibration and disables it only after waiting for done status from >>>>>> the calibration logic. >>>>>> >>>>>> This patch renames tegra_mipi_calibrate() as >>>>>> tegra_mipi_start_calibration() >>>>>> and tegra_mipi_wait() as tegra_mipi_finish_calibration() to be inlin= e >>>>>> with their usage. >>>>>> >>>>>> As MIPI clock is left enabled and in case of any failures with CSI >>>>>> input >>>>>> streaming tegra_mipi_finish_calibration() will not get invoked. >>>>>> So added new API tegra_mipi_cancel_calibration() which disables >>>>>> MIPI clock >>>>>> and consumer drivers can call this in such cases. >>>>>> >>>>>> Reviewed-by: Dmitry Osipenko >>>>>> Signed-off-by: Sowjanya Komatineni >>>>>> --- >>>>>> =C2=A0 drivers/gpu/drm/tegra/dsi.c |=C2=A0 4 ++-- >>>>>> =C2=A0 drivers/gpu/host1x/mipi.c=C2=A0=C2=A0 | 19 ++++++++++-------= -- >>>>>> =C2=A0 include/linux/host1x.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0= 5 +++-- >>>>>> =C2=A0 3 files changed, 15 insertions(+), 13 deletions(-) >>>>>> >>>>>> diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi= .c >>>>>> index 3820e8d..a7864e9 100644 >>>>>> --- a/drivers/gpu/drm/tegra/dsi.c >>>>>> +++ b/drivers/gpu/drm/tegra/dsi.c >>>>>> @@ -694,11 +694,11 @@ static int tegra_dsi_pad_calibrate(struct >>>>>> tegra_dsi *dsi) >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DSI_PAD_PREE= MP_PD(0x03) | DSI_PAD_PREEMP_PU(0x3); >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tegra_dsi_writel(dsi, value, DSI_PAD= _CONTROL_3); >>>>>> =C2=A0 -=C2=A0=C2=A0=C2=A0 err =3D tegra_mipi_calibrate(dsi->mipi); >>>>>> +=C2=A0=C2=A0=C2=A0 err =3D tegra_mipi_start_calibration(dsi->mipi); >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (err < 0) >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return err; >>>>>> =C2=A0 -=C2=A0=C2=A0=C2=A0 return tegra_mipi_wait(dsi->mipi); >>>>>> +=C2=A0=C2=A0=C2=A0 return tegra_mipi_finish_calibration(dsi->mipi); >>>>>> =C2=A0 } >>>>>> =C2=A0 =C2=A0 static void tegra_dsi_set_timeout(struct tegra_dsi *d= si, >>>>>> unsigned long bclk, >>>>>> diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c >>>>>> index e606464..b15ab6e 100644 >>>>>> --- a/drivers/gpu/host1x/mipi.c >>>>>> +++ b/drivers/gpu/host1x/mipi.c >>>>>> @@ -293,17 +293,19 @@ int tegra_mipi_disable(struct >>>>>> tegra_mipi_device *dev) >>>>>> =C2=A0 } >>>>>> =C2=A0 EXPORT_SYMBOL(tegra_mipi_disable); >>>>>> =C2=A0 -int tegra_mipi_wait(struct tegra_mipi_device *device) >>>>>> +void tegra_mipi_cancel_calibration(struct tegra_mipi_device *device= ) >>>>>> +{ >>>>>> +=C2=A0=C2=A0=C2=A0 clk_disable(device->mipi->clk); >>>>> Do we need to do anything with the MIPI_CAL_CTRL and MIPI_CAL_STATUS >>>>> registers here? We don't clear the START bit in the former when the >>>>> calibration has successfully finished, but I suspect that's because >>>>> the bit is self-clearing. But I wonder if we still need to clear it >>>>> upon cancellation to make sure the calibration does indeed stop. >>>> Apparently there is no way to explicitly stop calibration other than t= o >>>> reset MIPI calibration block, but Sowjanya says this is unnecessary. >>>> >>>> Perhaps having a fixed delay before disabling clock could be enough to >>>> ensure that calibration is stopped before the clock is disabled? >>>> >>> Actually, there is a MIPI_CAL_ACTIVE bit in the status register. Maybe >>> it needs to be polled until it's unset? >> Confirmed with HW design team during this patch update. >> >> SW does not need to clear START bit and only write 1 takes effect to >> that bit. >> >> Also, no need to have delay or do any other register settings unclear as >> its FSM and there's nothing to get stuck. >> >> Also it goes thru small finite set of codes and by the time sensor >> programming happens for enabling streaming FSM will finish its >> calibration sequence much early and it will only wait for pads LP-11. >> >> So, during cancel we only need disable MIPI clock. >> > But there is no guarantee that cancel_calibration() couldn't be invoked > in the middle of the calibration process, hence FSM could freeze in an > intermediate state if it's running on the disabled MIPI clock, this > doesn't sound good. Actual calibration logic uses UART_FST_CAL clock which is always enabled