Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp795072pxa; Wed, 5 Aug 2020 12:59:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxN6grDpo1MYEBgzJPfcsh5aFY6yoPp4LTdxKhWeU9/wOa9MOnwQJ/iZhRSaTWpeiD6bp8b X-Received: by 2002:aa7:d410:: with SMTP id z16mr866877edq.287.1596657543618; Wed, 05 Aug 2020 12:59:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596657543; cv=none; d=google.com; s=arc-20160816; b=Pbicd8BaiJKx10ECuDSMv9RNHrbv0b34yAkXIofbD91SGNyD5zkW+8zkeO+UFyEuvw emazupNn3wAAFwblZJkU79JLlHLSGw8rO0z3OMsNmkxynvQCmrRCmzc8DkUqCyolFvqG yAw9n/WtQNKxrVjwFYZVhXStCVlOe5HH9Hnwh6cqRjybm5YFGqeJwUllu4S8Tdffzrbz +GgFuPcNH+XTxXR+tbkG/l9vVgvX0s3ybvQ+Hv7ObZOoe+eu28ZZYvh7aC6TzxcbuwR7 muiB0b+1yOtoWFU6aaIqAUpvxMsv+U9i6M4RzYOzKZUKnz2eGFIw0BPnXMroaKDQ9d5F +zIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :dkim-signature; bh=ymSp4PIW1iklpKRZ7s5LPng5aoYV9shgptoEdnu23SM=; b=F6Exe+5VBzng8C/9vZBhpBLIIOy6qcnCj6ky89vbgxBDYqNPod2QaQiad9llbWDsvy 8olzP+5k96ybHmyaOhA5EHN/JDLCjPGN5gsiOuUfNDr83+U0DoVMngbgvqZNEKffo5DO wgB7NOHMqXnsb0DxPZTUonzqBjAQmooOEMLu3HXHMO3p2NTQ5/OY9aw5NvrJkTCZ54nv U79y6ads0on8qe8Wh9tV8vdklp1PwGBDt5qjQtNkVzkq1jdxFZ2m/cL3aOzkH6b5uC+j xoz4CkWya/Uxq3F+NSNMmljAbRNj/c+J0EwCpuK6yug1Kja1hTyorXQDlgUByvHdVoyQ eeVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cZHcYmzE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k22si2071682edv.26.2020.08.05.12.58.40; Wed, 05 Aug 2020 12:59:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cZHcYmzE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728296AbgHET40 (ORCPT + 99 others); Wed, 5 Aug 2020 15:56:26 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:33042 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727978AbgHEQoW (ORCPT ); Wed, 5 Aug 2020 12:44:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596645859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ymSp4PIW1iklpKRZ7s5LPng5aoYV9shgptoEdnu23SM=; b=cZHcYmzE9r/tv3b5wNvyxrcDtlq/aaTlJVxzu1IOxFW+CWRiWP3lAopcjTEGuEPhkCUQLW LQsgFnpqaOdu+AsTu1x+NSNfFbM5+XTmb5ovbZJr2efWifiYnl+6ev1S8ei01jLcQJsGSA dlOjULjDpMp2wwb8Bh4H4BWtdphvFzs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-4W7hKjd4NCeORz2QHj-HnQ-1; Wed, 05 Aug 2020 12:44:17 -0400 X-MC-Unique: 4W7hKjd4NCeORz2QHj-HnQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4333957; Wed, 5 Aug 2020 16:44:15 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-32.rdu2.redhat.com [10.10.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id CDCF65F202; Wed, 5 Aug 2020 16:44:12 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200804140558.GF32719@miu.piliscsaba.redhat.com> References: <20200804140558.GF32719@miu.piliscsaba.redhat.com> <159646178122.1784947.11705396571718464082.stgit@warthog.procyon.org.uk> <159646191446.1784947.11228235431863356055.stgit@warthog.procyon.org.uk> To: Miklos Szeredi Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, raven@themaw.net, mszeredi@redhat.com, christian@brauner.io, jannh@google.com, darrick.wong@oracle.com, kzak@redhat.com, jlayton@redhat.com, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/18] fsinfo: Add an attribute that lists all the visible mounts in a namespace [ver #21] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2325154.1596645852.1@warthog.procyon.org.uk> Date: Wed, 05 Aug 2020 17:44:12 +0100 Message-ID: <2325155.1596645852@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi wrote: > > where each element contains a once-in-a-system-lifetime unique ID, the > > mount ID (which may get reused), the parent mount ID and sums of the > > notification/change counters for the mount and its superblock. > > The change counters are currently conditional on CONFIG_MOUNT_NOTIFICATIONS. > Is this is intentional? Yeah - the counters aren't driven unless CONFIG_MOUNT_NOTIFICATIONS=y. I could perhaps make it so they're driven in both cases, but driving the in-subtree counter is somewhat tied up in the notification posting. This is something that can be fixed after this patchset is taken - if it is taken since that doesn't change the UAPI. David