Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp801228pxa; Wed, 5 Aug 2020 13:07:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUmE8C7pHnYMiI8NghQh4xdoYJeU+LQTzggEjY5eaSFD5nRp199I8VQKh5n19Iu/0zX9Gh X-Received: by 2002:a17:906:15c7:: with SMTP id l7mr1018816ejd.208.1596658031879; Wed, 05 Aug 2020 13:07:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596658031; cv=none; d=google.com; s=arc-20160816; b=UxSguSiga8WIXxvHMq5KwpX6Fkomk8ldK4gmM/7A1nJbpert7FcXBqiMM1p8tESbo4 GXXniLnmL1iFn18aWIlHVM/qkwSxGVmh2dKOW45etVOL0dyzQU2x/Su+eXLv9RjeKd1f 6TW19j4J/oFVHs4jwudc9wUcloMacPmHjs30SwWT0jp7Xc3xLWALVEGdP/DSZHGuo7m7 W0izIUEK9vM6zutN1kV2QyMgvZKZeWjWABQVJ1a4PiNRwkTRZ1hl57SvVos8+t5OHf03 nmbPZxrX/FNYPQuHi7IQoVBliku4r8A2v1sfC4mqtbYKmrwh0ZNJCc5pZ29HnSmczpIn /jZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WClhIINmirm/N/XMc2ys0t8dgCDn7pW8qEmgs/+jfsU=; b=zqzLuTL1JGD7nnmeVPlqPCwvPqdLBa4Prl4ADtwgJts/1bFke8QQSZPTMVlOVo6jQx MxQkwLfyNtDS4d1oEWdR5tw45SprtCZkXHzeb9shDN3yOjl/8weVA+nrDB5Sx0vqEN1A NDBaaDFz8MLV8f8Zrq9xPvt6TW9/Y6PG5e7I0Qm4KE4omIHgpiPWdRxBUNZId4RQytcl fwlBG0wtwGpuRYHbZSMuEZj8y6IFU6xjzBtItoW/aOu8VYVH0rgTWamSozATWJSOTNXG kw4N3LYfurl+ZFK4+plmCujEgXGO4X7T6pcICVuhkWDwUl2XUi17GEN//GO9NFFefqaB rmOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tEXEy2Ew; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x24si1948754ejs.198.2020.08.05.13.06.49; Wed, 05 Aug 2020 13:07:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tEXEy2Ew; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728248AbgHEUEl (ORCPT + 99 others); Wed, 5 Aug 2020 16:04:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:50664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727804AbgHEQgh (ORCPT ); Wed, 5 Aug 2020 12:36:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DBB22233A2; Wed, 5 Aug 2020 15:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596642797; bh=h3F50YRu/vJdUAaf8yXaUUqx+mIxdpj9HxIcTXfF7B0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tEXEy2EwPqjRoexBABNw6w2M8YvntZejUJDXFT196htHUB2EIthsjSeViq3KH0flr 9z2QnW3b7GKefoLyCpY4pVTEG+V0JwuqgNndU7OqgLEkrx8r8pwR2FcFR3ZtlqLe76 sboVOYP5PQGjulFLHNqQg5M1MnxiXJkcFTnRsd6Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stephen Rothwell , Emese Revfy , Kees Cook , Willy Tarreau , Linus Torvalds Subject: [PATCH 4.19 4/6] random32: remove net_rand_state from the latent entropy gcc plugin Date: Wed, 5 Aug 2020 17:53:03 +0200 Message-Id: <20200805153505.696556762@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200805153505.472594546@linuxfoundation.org> References: <20200805153505.472594546@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Torvalds commit 83bdc7275e6206f560d247be856bceba3e1ed8f2 upstream. It turns out that the plugin right now ends up being really unhappy about the change from 'static' to 'extern' storage that happened in commit f227e3ec3b5c ("random32: update the net random state on interrupt and activity"). This is probably a trivial fix for the latent_entropy plugin, but for now, just remove net_rand_state from the list of things the plugin worries about. Reported-by: Stephen Rothwell Cc: Emese Revfy Cc: Kees Cook Cc: Willy Tarreau Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- include/linux/random.h | 2 +- lib/random32.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/include/linux/random.h +++ b/include/linux/random.h @@ -116,7 +116,7 @@ struct rnd_state { __u32 s1, s2, s3, s4; }; -DECLARE_PER_CPU(struct rnd_state, net_rand_state) __latent_entropy; +DECLARE_PER_CPU(struct rnd_state, net_rand_state); u32 prandom_u32_state(struct rnd_state *state); void prandom_bytes_state(struct rnd_state *state, void *buf, size_t nbytes); --- a/lib/random32.c +++ b/lib/random32.c @@ -48,7 +48,7 @@ static inline void prandom_state_selftes } #endif -DEFINE_PER_CPU(struct rnd_state, net_rand_state) __latent_entropy; +DEFINE_PER_CPU(struct rnd_state, net_rand_state); /** * prandom_u32_state - seeded pseudo-random number generator.