Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 5 Aug 2020 19:15:48 -0300
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     "Dey, Megha" <megha.dey@intel.com>
Cc:     Marc Zyngier <maz@kernel.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>, "Lu, Baolu" <baolu.lu@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "Kumar, Sanjay K" <sanjay.k.kumar@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "Lin, Jing" <jing.lin@intel.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "parav@mellanox.com" <parav@mellanox.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        "netanelg@mellanox.com" <netanelg@mellanox.com>,
        "shahafs@mellanox.com" <shahafs@mellanox.com>,
        "yan.y.zhao@linux.intel.com" <yan.y.zhao@linux.intel.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Ortiz, Samuel" <samuel.ortiz@intel.com>,
        "Hossain, Mona" <mona.hossain@intel.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI
 irq domain
Message-ID: <20200805221548.GK19097@mellanox.com>
References: <159534667974.28840.2045034360240786644.stgit@djiang5-desk3.ch.intel.com>
 <159534734833.28840.10067945890695808535.stgit@djiang5-desk3.ch.intel.com>
 <878sfbxtzi.wl-maz@kernel.org>
 <20200722195928.GN2021248@mellanox.com>
 <96a1eb5ccc724790b5404a642583919d@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <96a1eb5ccc724790b5404a642583919d@intel.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (156.34.48.30) by MN2PR19CA0049.namprd19.prod.outlook.com (2603:10b6:208:19b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.18 via Frontend Transport; Wed, 5 Aug 2020 22:15:52 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@mellanox.com>)      id 1k3RhM-003y3S-5X; Wed, 05 Aug 2020 19:15:48 -0300
X-Originating-IP: [156.34.48.30]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 92c67b6d-392b-4dbc-cb85-08d8398d1da5
X-MS-TrafficTypeDiagnostic: VI1PR0501MB2752:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0501MB2752FEF03BF2ABEAD3727939CF4B0@VI1PR0501MB2752.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: X4QPhSxaPlC7QLX+WRi959s8pnbgAjANXpABwgAH64KQ2dRaJu+Oft3tbsa8pxu0f8hbmRKt6YH576TlGvxYEOuVlQuzYfZYjbFvd2NFQMHbyoQSR07FyCgoKI522GlV5vQk8pFld+C1nNem+QJkt3GzUYmFFdYkN7IB8t8vO6cLgxytLcmNe8uton3vaLNJX86yN94RT2ERQiQybnood/OdcVYT/tVfB5+Szi9M4ocL+cpk1SNIFit1hxMJR06Y3whjzNh7Ktu0qSpXFL/Y85lcAVFsVy9yU05vRKqOsboqVKW2pyu4X2ICVXWvOERRPyAWZ+QdBudvo8sE5GI5Vw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR05MB4141.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(39860400002)(136003)(366004)(396003)(26005)(2616005)(66476007)(4744005)(186003)(66946007)(426003)(4326008)(66556008)(5660300002)(36756003)(6916009)(478600001)(8936002)(7406005)(86362001)(9786002)(1076003)(54906003)(9746002)(7416002)(83380400001)(8676002)(316002)(2906002)(33656002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: IUUGv9G2VLsYUWdAKbt0940wg6pPGgY+qqQQegOeJn2y3zaGpWS+kNM+twd/KVAWOvRjRu6xbFE4Uua6H81eFAPuQJ44wqguwbu3foW9gpmhdYvYgE1vee4R6zznQv3brsLIX1SauLdl0JsTkMagLuPiIL3xdbLhYzGHKVXj5RBDGfhZaNXdGNX49aIjmhczSqyJggVv5Um5z5e7OuKXkkE5i9wTcEXyk7tsc7piFEY2HMoEBPGOKp7jQrVjg4FkG+k0PoFAAxv2dV81WEEpG90LYJkTSz0Xhj6u5CWUhwUvBBdGWDqW1WI1NCvuwfKrDb1dvJoiLe1x6k80KNhqWebt6033LuaOxYze/1R72JassDTk7kdig3CWbm1GFx1DowM8jiaPlmE46GN2PO9gkoaf2J/A2Xmz/oCDQ9JLiBPt6/AfgdQbI92/xUSrSbtZoP9HNUXrEfvpu65tlajNtQC//iYt/VMuSHUUUBblDPeB+nYBQM3UbGqCF7PRct8WjGi1M6BiuKn2+CQtkfvUZirPR+8/i/qBzwB1oitUsn5ZXpevpo+iMOI/owhL9h8R53syYAQ+tdGX/FFR/UZ69yfhrbUBwkdh0Mzhz/YTc9FFvpgt+E/hzwoBHG7+vNKYATlAgj8kXaSR5brbLDk2Og==
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92c67b6d-392b-4dbc-cb85-08d8398d1da5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR05MB4141.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2020 22:15:53.0288
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RJ82ogLvm5j5p/dHxWWNfjjFmXpUuQLpl5AMrlFgt2BN9+3UmAeA1/sPVmVoqldPQHNZA2cu0GRvQK7TlVHeng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2752
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 05, 2020 at 07:18:39PM +0000, Dey, Megha wrote:

> Hence we will only have one create_dev_msi_domain which can be
> called by any device driver that wants to use the dev-msi IRQ domain
> to alloc/free IRQs. It would be the responsibility of the device
> driver to provide the correct device and update the dev->msi_domain.

I'm not sure that sounds like a good idea, why should a device driver
touch dev->msi_domain?

There was a certain appeal to the api I suggested by having everything
related to setting up the new IRQs being in the core code.

Jason